accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Corey Nolet" <cjno...@gmail.com>
Subject Re: Review Request 29959: ACCUMULO-2793 Adding non-HA to HA migration info to user manual and log error when improperly configuring instance.volumes.
Date Fri, 16 Jan 2015 05:01:03 GMT


> On Jan. 16, 2015, 4:57 a.m., Josh Elser wrote:
> > server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java, line
39
> > <https://reviews.apache.org/r/29959/diff/1/?file=823371#file823371line39>
> >
> >     Unnecessary change?

You are right- originally I had the error log in this class but then I moved it. I'll remove
this.


> On Jan. 16, 2015, 4:57 a.m., Josh Elser wrote:
> > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java, line
506
> > <https://reviews.apache.org/r/29959/diff/1/?file=823372#file823372line506>
> >
> >     Unnecessary change?

This happened when I ran the formatter.


- Corey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29959/#review68407
-----------------------------------------------------------


On Jan. 16, 2015, 4:37 a.m., Corey Nolet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29959/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2015, 4:37 a.m.)
> 
> 
> Review request for accumulo, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-2793 Adding info to user manual about migration from non-HA to HA as well as
an error message when a replaced instance appears in instance.volumes
> 
> 
> Diffs
> -----
> 
>   docs/src/main/latex/accumulo_user_manual/chapters/administration.tex 4b917d1 
>   server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 51fa47e 
>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java e0a3797 
> 
> Diff: https://reviews.apache.org/r/29959/diff/
> 
> 
> Testing
> -------
> 
> Built the manual and found that the page numbers aren't aligning with the table of contents.
Opened up ACCUMULO-3486 to address this. Still need to verify if it's a recent bug or if it's
been around for awhile.
> 
> Physically tested the error message appears when 'bin/accumulo init --add-volumes' is
called and a replaced volume appears in instance.volumes. Also verified that the error does
not appear when 'bin/accumulo init --add-volumes' is called and the replaced volume does not
appear in instance.volumes
> 
> 
> Thanks,
> 
> Corey Nolet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message