accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs" <ctubbsii...@apache.org>
Subject Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo
Date Fri, 09 Jan 2015 19:28:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29176/#review67491
-----------------------------------------------------------



core/src/main/java/org/apache/accumulo/core/file/rfile/VisMetricsGatherer.java
<https://reviews.apache.org/r/29176/#comment111532>

    Should have some javadoc explaining the kinds of metrics this class provides.
    
    In other words, what can we expect to be contained in `Map<String,ArrayList<String>>`
when we call `getMetrics()`?



core/src/main/java/org/apache/accumulo/core/file/rfile/VisMetricsGatherer.java
<https://reviews.apache.org/r/29176/#comment111534>

    Instead of serializing to a string, you could return use simple object (with getters)
representing these pieces of data, and move the formatting outside.


- Christopher Tubbs


On Jan. 9, 2015, 11:19 a.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29176/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 11:19 a.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3420
>     https://issues.apache.org/jira/browse/ACCUMULO-3420
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Added an option to PrintInfo to get visibility metrics.  Prints the number of times a
visibilty is seen in each locality group.  Also shows how many blocks in the locality group
have his visibiltiy.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java PRE-CREATION

>   core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java f29efcc 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java 0b464d8 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/VisMetricsGatherer.java PRE-CREATION

>   core/src/test/java/org/apache/accumulo/core/file/rfile/RFileMetricsTest.java PRE-CREATION

>   core/src/test/java/org/apache/accumulo/core/file/rfile/RFileTest.java 1a83f33 
> 
> Diff: https://reviews.apache.org/r/29176/diff/
> 
> 
> Testing
> -------
> 
> Tested with a few RFiles that I made.
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message