accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Newton" <eric.new...@gmail.com>
Subject Re: Review Request 29230: ACCUMULO-3439 Add RegexGroupBalancer
Date Tue, 06 Jan 2015 21:41:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29230/#review66915
-----------------------------------------------------------


Nit: whitespace
Nit: single-line statements w/out braces


server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110619>

    final



server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110620>

    this(null);



server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110621>

    final



server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110622>

    final



server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110623>

    final



server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110624>

    final



server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110625>

    @Override



server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110626>

    @Override



server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110627>

    @Override



server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
<https://reviews.apache.org/r/29230/#comment110628>

    Could this class be made static by passing in the table ID?


- Eric Newton


On Dec. 19, 2014, 1:52 a.m., kturner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29230/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2014, 1:52 a.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3439
>     https://issues.apache.org/jira/browse/ACCUMULO-3439
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> The patch contains a new balancer, test, and documentation.
> 
> 
> Diffs
> -----
> 
>   docs/src/main/resources/examples/README.rgbalancer PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/master/balancer/RegexGroupBalancer.java
PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/master/balancer/TableLoadBalancer.java
5eae890 
>   server/base/src/test/java/org/apache/accumulo/server/master/balancer/GroupBalancerTest.java
PRE-CREATION 
>   test/src/test/java/org/apache/accumulo/test/functional/RegexGroupBalanceIT.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/29230/diff/
> 
> 
> Testing
> -------
> 
> The new unit test and intergeration test added in the patch run.  
> 
> 
> Thanks,
> 
> kturner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message