Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D966CF8D9 for ; Fri, 12 Dec 2014 16:36:59 +0000 (UTC) Received: (qmail 55182 invoked by uid 500); 12 Dec 2014 16:36:59 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 55140 invoked by uid 500); 12 Dec 2014 16:36:59 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 55113 invoked by uid 99); 12 Dec 2014 16:36:58 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Dec 2014 16:36:58 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1454B1D2371; Fri, 12 Dec 2014 16:36:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6680164402700569857==" MIME-Version: 1.0 Subject: Re: Review Request 28873: ACCUMULO-3393 Follow-on work for per-table volume chooser. From: "Sean Busbey" To: "Jenna Huston" Cc: "Mike Drob" , "Sean Busbey" , "accumulo" , "Eric Newton" , "Christopher Tubbs" , "Josh Elser" Date: Fri, 12 Dec 2014 16:36:56 -0000 Message-ID: <20141212163656.5766.59997@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sean Busbey" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/28873/ X-Sender: "Sean Busbey" References: <20141211081424.26419.3352@reviews.apache.org> In-Reply-To: <20141211081424.26419.3352@reviews.apache.org> Reply-To: "Sean Busbey" X-ReviewRequest-Repository: accumulo --===============6680164402700569857== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28873/ ----------------------------------------------------------- (Updated Dec. 12, 2014, 4:36 p.m.) Review request for accumulo and Jenna Huston. Changes ------- rebased to current master, updated to use commons.lang.StringUtils.split, made generic type for filtered choices explicit. Bugs: ACCUMULO-3393 https://issues.apache.org/jira/browse/ACCUMULO-3393 Repository: accumulo Description ------- ACCUMULO-3393 Follow-on work for per-table volume chooser. Still has TODOs for additional tickets I need to file. I'll update the review to remove once I have them all filed. I think everything marked TODO can wait for a later ticket. Please comment on relevant section if you think something needs to be done now. * docs clean up + code guideline compliance. * ensure RandomVolumeChoosers are independent when used per-table. * make sure that per-table choosers can keep state the way that global choosers can * make sure that a chooser can only pick from the options it is presented. * reduce object creation in critical path for Tablet.split. Diffs (updated) ----- core/src/main/java/org/apache/accumulo/core/conf/Property.java 4c2d0b41b3bce32449861da3ac42fa27deb2b182 server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java 7a825c796eb5a25de8c748e2aba642f483697b9a server/base/src/main/java/org/apache/accumulo/server/fs/PreferredVolumeChooser.java 7ed7bba809a4e5e4b2d472c3327b15adb37251a7 server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java f2eb2113cb848ed58ac5f41573c6ff2cde9b0a77 server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java f523057b11a2dc42e82010675bb1ac8e3802f96d server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java 890651e92f4c34514cb839b7b9ee9d23ad55070a server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java dc1be739b634d91992894f8f27c2d9c184bd98cd server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 877d01c2233cca086c1ac1539eb81cc282a7ceb4 server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java c0e1a9b991d61a4dbb127c74ae297f171434e7d5 server/base/src/test/java/org/apache/accumulo/server/fs/VolumeManagerImplTest.java 582822a8ccbc398925a2184eed0b9d7fa853f9b4 Diff: https://reviews.apache.org/r/28873/diff/ Testing ------- Ran through VolumeManagerImplTest and VolumeChooserIT Thanks, Sean Busbey --===============6680164402700569857==--