accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Re: Review Request 29502: ACCUMULO-3458 Adding scan authorizations to IteratorEnvironment
Date Wed, 31 Dec 2014 04:30:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29502/#review66439
-----------------------------------------------------------


Neat stuff, Corey!


core/src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java
<https://reviews.apache.org/r/29502/#comment109983>

    Can't you pull this from the Scanner?



server/tserver/src/main/java/org/apache/accumulo/tserver/TabletIteratorEnvironment.java
<https://reviews.apache.org/r/29502/#comment109984>

    It looks like TabletIteratorEnvironment is used for minor compactions. Isn't always setting
`Authorizations.EMPTY` a little misleading? Is there something more representative of having
all auths we could do here? Maybe extra documentation is enough? Could also throw UnsupportedOperationException
or similar when the IteratorScope is something that isn't SCAN?



test/src/test/java/org/apache/accumulo/test/ScanIteratorIT.java
<https://reviews.apache.org/r/29502/#comment109986>

    Please create a user, assign it the auths you need, and then remove the user after the
test.
    
    If this test is run against a standalone instance, it should try to leave the system in
the same state the test started in.



test/src/test/java/org/apache/accumulo/test/ScanIteratorIT.java
<https://reviews.apache.org/r/29502/#comment109985>

    Close the batchwriter.


- Josh Elser


On Dec. 31, 2014, 4:05 a.m., Corey Nolet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29502/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2014, 4:05 a.m.)
> 
> 
> Review request for accumulo, Christopher Tubbs, Eric Newton, Josh Elser, and kturner.
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-3458 Propagating scan-time authorizations through the IteratorEnvironment so
that scan-time iterators can use them.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java 4903656

>   core/src/main/java/org/apache/accumulo/core/client/impl/OfflineScanner.java 2552682

>   core/src/main/java/org/apache/accumulo/core/client/mock/MockScannerBase.java 72cb863

>   core/src/main/java/org/apache/accumulo/core/iterators/IteratorEnvironment.java 9e20cb1

>   core/src/main/java/org/apache/accumulo/core/iterators/system/VisibilityFilter.java
15c33fa 
>   core/src/test/java/org/apache/accumulo/core/iterators/DefaultIteratorEnvironment.java
94da7b5 
>   core/src/test/java/org/apache/accumulo/core/iterators/FirstEntryInRowIteratorTest.java
fa46360 
>   core/src/test/java/org/apache/accumulo/core/iterators/user/RowDeletingIteratorTest.java
4521e55 
>   core/src/test/java/org/apache/accumulo/core/iterators/user/TransformingIteratorTest.java
4cebab7 
>   server/base/src/test/java/org/apache/accumulo/server/iterators/MetadataBulkLoadFilterTest.java
4a45e99 
>   server/base/src/test/java/org/apache/accumulo/server/replication/StatusCombinerTest.java
a9801b0 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletIteratorEnvironment.java
d1fece5 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Compactor.java 869cc33

>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java
fe4b16b 
>   test/src/main/java/org/apache/accumulo/test/functional/AuthsIterator.java PRE-CREATION

>   test/src/test/java/org/apache/accumulo/test/ScanIteratorIT.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29502/diff/
> 
> 
> Testing
> -------
> 
> Wrote an integration test to verify that ScanDataSource is actually setting the authorizations
on the IteratorEnvironment
> 
> 
> Thanks,
> 
> Corey Nolet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message