accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request 29176: ACCUMULO-3420 Get Visibility Metrics from PrintInfo
Date Thu, 18 Dec 2014 15:59:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29176/#review65498
-----------------------------------------------------------



core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java
<https://reviews.apache.org/r/29176/#comment108703>

    Is there an assumption that the order of elements in the list returned in this method
will end up corresponding to the order of groups in the other list?  If so that could easily
break.  
    
    Could add a unit test that checks this assumption.  
    
    Alternatively could use locality group names to join these two data sets.  Have  `getLocalityGroupCF()`
return `Map<String,ArrayList<ByteSequence>>` where the map key is LG name.  The
method `newLocalityGroup()` could take a name and keep a mapping of names to ints.



core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java
<https://reviews.apache.org/r/29176/#comment108705>

    RFile has extensive test in the unit test RFileTest.  These test create RFiles in memory.
 Would be nice to add test to verify metrics work as expected.



core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java
<https://reviews.apache.org/r/29176/#comment108704>

    AFAICT there is no printing happening here?  Should this method be called `setMetricsGatherer()`?


- kturner


On Dec. 17, 2014, 8:31 p.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29176/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 8:31 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3420
>     https://issues.apache.org/jira/browse/ACCUMULO-3420
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Added an option to PrintInfo to get visibility metrics.  Prints the number of times a
visibilty is seen in each locality group.  Also shows how many blocks in the locality group
have his visibiltiy.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/MetricsGatherer.java PRE-CREATION

>   core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java 43586dd 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java 9dcb3a5 
> 
> Diff: https://reviews.apache.org/r/29176/diff/
> 
> 
> Testing
> -------
> 
> Tested with a few RFiles that I made.
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message