accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Review Request 29001: Reintroduce mapred(uce) classes in core for 1.5/1.6 compat and rename package for classes in mapreduce module
Date Fri, 12 Dec 2014 16:53:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29001/
-----------------------------------------------------------

Review request for accumulo.


Bugs: ACCUMULO-3402
    https://issues.apache.org/jira/browse/ACCUMULO-3402


Repository: accumulo


Description
-------

Moving mapred(uce) classes outside of the core module breaks all downstream consumers of the
code who use the dependencies. Consumers would have to implement custom profiles in order
to support compilation against both 1.6 and 1.7 which is obnoxious. This restores the classes
in core/ (with tests), removes the core/client portion of the package name from mapreduce/
class names, and changes the codebase to use the classes from mapreduce/.

MR classes in core/ are deprecated now to properly advertise this recommendation to not use.


Diffs
-----

  core/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java PRE-CREATION

  core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloFileOutputFormat.java
PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloInputFormat.java PRE-CREATION

  core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloMultiTableInputFormat.java
PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloOutputFormat.java PRE-CREATION

  core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloRowInputFormat.java PRE-CREATION

  core/src/main/java/org/apache/accumulo/core/client/mapred/InputFormatBase.java PRE-CREATION

  core/src/main/java/org/apache/accumulo/core/client/mapred/RangeInputSplit.java PRE-CREATION

  core/src/main/java/org/apache/accumulo/core/client/mapreduce/AbstractInputFormat.java PRE-CREATION

  core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloFileOutputFormat.java
PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormat.java PRE-CREATION

  core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloMultiTableInputFormat.java
PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java PRE-CREATION

  core/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloRowInputFormat.java
PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java PRE-CREATION

  core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputTableConfig.java PRE-CREATION

  core/src/main/java/org/apache/accumulo/core/client/mapreduce/RangeInputSplit.java PRE-CREATION

  core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/ConfiguratorBase.java
PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/DistributedCacheHelper.java
PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/FileOutputConfigurator.java
PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/InputConfigurator.java
PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/OutputConfigurator.java
PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/package-info.java
PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/partition/KeyRangePartitioner.java
PRE-CREATION 
  core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/partition/RangePartitioner.java
PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/client/mapred/AccumuloFileOutputFormatTest.java
PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/client/mapred/AccumuloInputFormatTest.java PRE-CREATION

  core/src/test/java/org/apache/accumulo/core/client/mapred/AccumuloMultiTableInputFormatTest.java
PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/client/mapred/AccumuloOutputFormatTest.java
PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/client/mapred/AccumuloRowInputFormatTest.java
PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/client/mapred/TokenFileTest.java PRE-CREATION

  core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloFileOutputFormatTest.java
PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormatTest.java
PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloMultiTableInputFormatTest.java
PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormatTest.java
PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloRowInputFormatTest.java
PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/client/mapreduce/BadPasswordSplitsAccumuloInputFormat.java
PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/client/mapreduce/EmptySplitsAccumuloInputFormat.java
PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/client/mapreduce/InputTableConfigTest.java PRE-CREATION

  core/src/test/java/org/apache/accumulo/core/client/mapreduce/RangeInputSplitTest.java PRE-CREATION

  core/src/test/java/org/apache/accumulo/core/client/mapreduce/TokenFileTest.java PRE-CREATION

  core/src/test/java/org/apache/accumulo/core/client/mapreduce/lib/impl/ConfiguratorBaseTest.java
PRE-CREATION 
  core/src/test/java/org/apache/accumulo/core/client/mapreduce/lib/partition/RangePartitionerTest.java
PRE-CREATION 
  examples/simple/src/main/java/org/apache/accumulo/examples/simple/filedata/CharacterHistogram.java
c760ee3 
  examples/simple/src/main/java/org/apache/accumulo/examples/simple/filedata/ChunkInputFormat.java
732b03b 
  examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/NGramIngest.java
6ae74ce 
  examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/RegexExample.java
d6695e6 
  examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/RowHash.java
06bfc8f 
  examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TableToFile.java
351a51c 
  examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TeraSortIngest.java
afbc4b0 
  examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/TokenFileWordCount.java
7bb7e69 
  examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/UniqueColumns.java
7c0b91a 
  examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/WordCount.java
4f1f861 
  examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/bulk/BulkIngestExample.java
354396c 
  mapreduce/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnDefaultTable.java
e7a3dd4 
  mapreduce/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOnRequiredTable.java
abfc17d 
  mapreduce/src/main/java/org/apache/accumulo/core/cli/MapReduceClientOpts.java 4b3b7ed 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java
b83a024 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloFileOutputFormat.java
cfaaa58 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloInputFormat.java
18e286a 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloMultiTableInputFormat.java
bbafef5 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloOutputFormat.java
a32a8b8 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloRowInputFormat.java
673c5b8 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/InputFormatBase.java 0cee355

  mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/RangeInputSplit.java 3fd2ab0

  mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/AbstractInputFormat.java
2866896 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloFileOutputFormat.java
196fb04 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormat.java
21a0280 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloMultiTableInputFormat.java
af1001f 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormat.java
e220c00 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloRowInputFormat.java
37caf15 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java e58e350

  mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/InputTableConfig.java
fa3b7eb 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/RangeInputSplit.java 29cf95d

  mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/ConfiguratorBase.java
ae1d46f 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/DistributedCacheHelper.java
c694b9a 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/FileOutputConfigurator.java
ce84209 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/InputConfigurator.java
af84bb4 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/OutputConfigurator.java
13b67d5 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/package-info.java
243160d 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/partition/KeyRangePartitioner.java
c59841d 
  mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/partition/RangePartitioner.java
c0c0097 
  mapreduce/src/main/java/org/apache/accumulo/mapred/AbstractInputFormat.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapred/AccumuloFileOutputFormat.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapred/AccumuloInputFormat.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapred/AccumuloMultiTableInputFormat.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapred/AccumuloOutputFormat.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapred/AccumuloRowInputFormat.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapred/InputFormatBase.java PRE-CREATION 
  mapreduce/src/main/java/org/apache/accumulo/mapred/RangeInputSplit.java PRE-CREATION 
  mapreduce/src/main/java/org/apache/accumulo/mapreduce/AbstractInputFormat.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapreduce/AccumuloFileOutputFormat.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapreduce/AccumuloInputFormat.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapreduce/AccumuloMultiTableInputFormat.java
PRE-CREATION 
  mapreduce/src/main/java/org/apache/accumulo/mapreduce/AccumuloOutputFormat.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapreduce/AccumuloRowInputFormat.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapreduce/InputFormatBase.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapreduce/InputTableConfig.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapreduce/RangeInputSplit.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapreduce/cli/MapReduceClientOnDefaultTable.java
PRE-CREATION 
  mapreduce/src/main/java/org/apache/accumulo/mapreduce/cli/MapReduceClientOnRequiredTable.java
PRE-CREATION 
  mapreduce/src/main/java/org/apache/accumulo/mapreduce/cli/MapReduceClientOpts.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapreduce/lib/impl/ConfiguratorBase.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapreduce/lib/impl/DistributedCacheHelper.java
PRE-CREATION 
  mapreduce/src/main/java/org/apache/accumulo/mapreduce/lib/impl/FileOutputConfigurator.java
PRE-CREATION 
  mapreduce/src/main/java/org/apache/accumulo/mapreduce/lib/impl/InputConfigurator.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapreduce/lib/impl/OutputConfigurator.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapreduce/lib/impl/package-info.java PRE-CREATION

  mapreduce/src/main/java/org/apache/accumulo/mapreduce/lib/partition/KeyRangePartitioner.java
PRE-CREATION 
  mapreduce/src/main/java/org/apache/accumulo/mapreduce/lib/partition/RangePartitioner.java
PRE-CREATION 
  mapreduce/src/test/java/org/apache/accumulo/core/client/mapred/AccumuloFileOutputFormatTest.java
3a4d641 
  mapreduce/src/test/java/org/apache/accumulo/core/client/mapred/AccumuloInputFormatTest.java
9991206 
  mapreduce/src/test/java/org/apache/accumulo/core/client/mapred/AccumuloMultiTableInputFormatTest.java
2864016 
  mapreduce/src/test/java/org/apache/accumulo/core/client/mapred/AccumuloOutputFormatTest.java
36054c8 
  mapreduce/src/test/java/org/apache/accumulo/core/client/mapred/AccumuloRowInputFormatTest.java
a0ae0b3 
  mapreduce/src/test/java/org/apache/accumulo/core/client/mapred/RangeInputSplitTest.java
88f5527 
  mapreduce/src/test/java/org/apache/accumulo/core/client/mapred/TokenFileTest.java 0e1fe39

  mapreduce/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloFileOutputFormatTest.java
2a453e3 
  mapreduce/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormatTest.java
869ae9d 
  mapreduce/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloMultiTableInputFormatTest.java
05fbbb4 
  mapreduce/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloOutputFormatTest.java
a0cb4e3 
  mapreduce/src/test/java/org/apache/accumulo/core/client/mapreduce/AccumuloRowInputFormatTest.java
2207437 
  mapreduce/src/test/java/org/apache/accumulo/core/client/mapreduce/BadPasswordSplitsAccumuloInputFormat.java
fce7781 
  mapreduce/src/test/java/org/apache/accumulo/core/client/mapreduce/EmptySplitsAccumuloInputFormat.java
dd531c0 
  mapreduce/src/test/java/org/apache/accumulo/core/client/mapreduce/InputTableConfigTest.java
4855094 
  mapreduce/src/test/java/org/apache/accumulo/core/client/mapreduce/RangeInputSplitTest.java
833e594 
  mapreduce/src/test/java/org/apache/accumulo/core/client/mapreduce/TokenFileTest.java fd207a1

  mapreduce/src/test/java/org/apache/accumulo/core/client/mapreduce/lib/impl/ConfiguratorBaseTest.java
7c1f98b 
  mapreduce/src/test/java/org/apache/accumulo/core/client/mapreduce/lib/partition/RangePartitionerTest.java
8fca169 
  mapreduce/src/test/java/org/apache/accumulo/mapred/AccumuloFileOutputFormatTest.java PRE-CREATION

  mapreduce/src/test/java/org/apache/accumulo/mapred/AccumuloInputFormatTest.java PRE-CREATION

  mapreduce/src/test/java/org/apache/accumulo/mapred/AccumuloMultiTableInputFormatTest.java
PRE-CREATION 
  mapreduce/src/test/java/org/apache/accumulo/mapred/AccumuloOutputFormatTest.java PRE-CREATION

  mapreduce/src/test/java/org/apache/accumulo/mapred/AccumuloRowInputFormatTest.java PRE-CREATION

  mapreduce/src/test/java/org/apache/accumulo/mapred/RangeInputSplitTest.java PRE-CREATION

  mapreduce/src/test/java/org/apache/accumulo/mapred/TokenFileTest.java PRE-CREATION 
  mapreduce/src/test/java/org/apache/accumulo/mapreduce/AccumuloFileOutputFormatTest.java
PRE-CREATION 
  mapreduce/src/test/java/org/apache/accumulo/mapreduce/AccumuloInputFormatTest.java PRE-CREATION

  mapreduce/src/test/java/org/apache/accumulo/mapreduce/AccumuloMultiTableInputFormatTest.java
PRE-CREATION 
  mapreduce/src/test/java/org/apache/accumulo/mapreduce/AccumuloOutputFormatTest.java PRE-CREATION

  mapreduce/src/test/java/org/apache/accumulo/mapreduce/AccumuloRowInputFormatTest.java PRE-CREATION

  mapreduce/src/test/java/org/apache/accumulo/mapreduce/BadPasswordSplitsAccumuloInputFormat.java
PRE-CREATION 
  mapreduce/src/test/java/org/apache/accumulo/mapreduce/EmptySplitsAccumuloInputFormat.java
PRE-CREATION 
  mapreduce/src/test/java/org/apache/accumulo/mapreduce/InputTableConfigTest.java PRE-CREATION

  mapreduce/src/test/java/org/apache/accumulo/mapreduce/RangeInputSplitTest.java PRE-CREATION

  mapreduce/src/test/java/org/apache/accumulo/mapreduce/TokenFileTest.java PRE-CREATION 
  mapreduce/src/test/java/org/apache/accumulo/mapreduce/lib/impl/ConfiguratorBaseTest.java
PRE-CREATION 
  mapreduce/src/test/java/org/apache/accumulo/mapreduce/lib/partition/RangePartitionerTest.java
PRE-CREATION 
  test/src/main/java/org/apache/accumulo/test/continuous/ContinuousIngest.java f54b8db 
  test/src/main/java/org/apache/accumulo/test/continuous/ContinuousMoru.java 797413f 
  test/src/main/java/org/apache/accumulo/test/continuous/ContinuousVerify.java 049f9b8 
  test/src/main/java/org/apache/accumulo/test/randomwalk/multitable/CopyTool.java d92dea2

  test/src/main/java/org/apache/accumulo/test/randomwalk/sequential/MapRedVerifyTool.java
3a078ef 
  test/src/main/java/org/apache/accumulo/test/randomwalk/shard/SortTool.java 17af89e 
  test/src/test/java/org/apache/accumulo/test/functional/AccumuloInputFormatIT.java fcd7afa


Diff: https://reviews.apache.org/r/29001/diff/


Testing
-------

Unit tests so far. Will be running ITs before commit.


Thanks,

Josh Elser


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message