accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request 28873: ACCUMULO-3393 Follow-on work for per-table volume chooser.
Date Wed, 10 Dec 2014 14:22:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28873/
-----------------------------------------------------------

(Updated Dec. 10, 2014, 2:22 p.m.)


Review request for accumulo and Jenna Huston.


Bugs: ACCUMULO-3393
    https://issues.apache.org/jira/browse/ACCUMULO-3393


Repository: accumulo


Description (updated)
-------

ACCUMULO-3393 Follow-on work for per-table volume chooser.

Still has TODOs for additional tickets I need to file. I'll update the review to remove once
I have them all filed. I think everything marked TODO can wait for a later ticket. Please
comment on relevant section if you think something needs to be done now.

* docs clean up + code guideline compliance.
* make sure that per-table choosers can keep state the way that global choosers can
* make sure that a chooser can only pick from the options it is presented.
* avoid object creation in critical path for Tablet.split.


Diffs
-----

  core/src/main/java/org/apache/accumulo/core/conf/Property.java 4c2d0b41b3bce32449861da3ac42fa27deb2b182

  pom.xml 31601a1bf84e19b861e4f48b50824eeb77987b52 
  server/base/pom.xml c21a168dec2092692f1ee6877c4703ee2d3e3977 
  server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java 7a825c796eb5a25de8c748e2aba642f483697b9a

  server/base/src/main/java/org/apache/accumulo/server/fs/PreferredVolumeChooser.java 7ed7bba809a4e5e4b2d472c3327b15adb37251a7

  server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java f2eb2113cb848ed58ac5f41573c6ff2cde9b0a77

  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java f523057b11a2dc42e82010675bb1ac8e3802f96d

  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java 890651e92f4c34514cb839b7b9ee9d23ad55070a

  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java dc1be739b634d91992894f8f27c2d9c184bd98cd

  server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 877d01c2233cca086c1ac1539eb81cc282a7ceb4

  server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java c0e1a9b991d61a4dbb127c74ae297f171434e7d5

  server/base/src/test/java/org/apache/accumulo/server/fs/VolumeManagerImplTest.java 582822a8ccbc398925a2184eed0b9d7fa853f9b4


Diff: https://reviews.apache.org/r/28873/diff/


Testing
-------

Ran through VolumeManagerImplTest and VolumeChooserIT 


Thanks,

Sean Busbey


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message