accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Re: Review Request 28739: ACCUMULO-3134 Added file selection and output configuration to compact command
Date Mon, 08 Dec 2014 20:39:19 GMT


> On Dec. 5, 2014, 3:45 p.m., Josh Elser wrote:
> > shell/src/main/java/org/apache/accumulo/shell/commands/CompactCommand.java, line
225
> > <https://reviews.apache.org/r/28739/diff/1/?file=783471#file783471line225>
> >
> >     What's the intent behind this option? Why would you ever want to compact some
of the files of a table with a different compression codec than what the table default is?
> >     
> >     Only reason I can come up with is importing files written with a different codec
and wanting to compact just those files.
> >     
> >     Actually, I'd have the same question against, datablock size, indexblock size,
hdfs replication, and hdfs block size options too.
> 
> kturner wrote:
>     One use case I was thinking of is using the compaction range option along w/ these
options to compact one tablet differently for performance testing.
> 
> Josh Elser wrote:
>     Ok, that's fine -- proper marketing should be sufficient. I was worried about the
implications of users finding these options and not understanding how they should actually
be used (that they'd just be 'undone' the next time a compaction over those tablets happens).

I was trying to think of an appropriate place to document this. Perhaps you could update the
"help" message on CompactCommand to give a warning about the use of the new options? I'm not
sure where in the user manual it would be appropriate to discuss them (I don't think we have
a perf tuning section yet..).


- Josh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28739/#review63998
-----------------------------------------------------------


On Dec. 5, 2014, 10:43 p.m., kturner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28739/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 10:43 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3134
>     https://issues.apache.org/jira/browse/ACCUMULO-3134
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Added file selection and output configuration to shell compact command
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/compaction/CompactionSettings.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/strategies/ConfigurableCompactionStrategy.java
PRE-CREATION 
>   server/tserver/src/test/java/org/apache/accumulo/tserver/compaction/strategies/ConfigurableCompactionStrategyTest.java
PRE-CREATION 
>   shell/src/main/java/org/apache/accumulo/shell/Shell.java 8927ee0 
>   shell/src/main/java/org/apache/accumulo/shell/commands/CompactCommand.java 660630e

>   test/src/test/java/org/apache/accumulo/test/ShellServerIT.java d878c7f 
> 
> Diff: https://reviews.apache.org/r/28739/diff/
> 
> 
> Testing
> -------
> 
> Added an IT that test file selection options on compact command.  IT does not test output
file configuration.
> 
> 
> Thanks,
> 
> kturner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message