accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob" <md...@mdrob.com>
Subject Re: Review Request 28739: ACCUMULO-3134 Added file selection and output configuration to compact command
Date Fri, 05 Dec 2014 21:54:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28739/#review64089
-----------------------------------------------------------



server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/strategies/ConfigurableCompactionStrategy.java
<https://reviews.apache.org/r/28739/#comment106507>

    I know we're not on Java 8, but it would still be nice if this could easily be retro-fitted
to https://docs.oracle.com/javase/8/docs/api/java/util/function/BiPredicate.html when we get
to that point. Or maybe the specific tests can implement BiPredicate.



server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/strategies/ConfigurableCompactionStrategy.java
<https://reviews.apache.org/r/28739/#comment106509>

    This is the part that would eventually benefit from functional interfaces.



shell/src/main/java/org/apache/accumulo/shell/commands/CompactCommand.java
<https://reviews.apache.org/r/28739/#comment106510>

    Should not be using System.out



shell/src/main/java/org/apache/accumulo/shell/commands/CompactCommand.java
<https://reviews.apache.org/r/28739/#comment106512>

    Refactor: create a two-argument helper method that takes a name and descriptions and calls
new Option(null, arg0, true, arg1).



test/src/test/java/org/apache/accumulo/test/ShellServerIT.java
<https://reviews.apache.org/r/28739/#comment106514>

    It bothers me that these are not in alphabetical order. :)
    
    Not worth fixing, but it just looked strange at first glance and I couldn't figure out
why.


- Mike Drob


On Dec. 5, 2014, 9:18 p.m., kturner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28739/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 9:18 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3134
>     https://issues.apache.org/jira/browse/ACCUMULO-3134
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Added file selection and output configuration to shell compact command
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/compaction/CompactionSettings.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/strategies/ConfigurableCompactionStrategy.java
PRE-CREATION 
>   shell/src/main/java/org/apache/accumulo/shell/Shell.java 8927ee0 
>   shell/src/main/java/org/apache/accumulo/shell/commands/CompactCommand.java 660630e

>   test/src/test/java/org/apache/accumulo/test/ShellServerIT.java d878c7f 
> 
> Diff: https://reviews.apache.org/r/28739/diff/
> 
> 
> Testing
> -------
> 
> Added an IT that test file selection options on compact command.  IT does not test output
file configuration.
> 
> 
> Thanks,
> 
> kturner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message