accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request 28739: ACCUMULO-3134 Added file selection and output configuration to compact command
Date Fri, 05 Dec 2014 21:21:18 GMT


> On Dec. 5, 2014, 5:59 p.m., Mike Drob wrote:
> > core/src/main/java/org/apache/accumulo/core/compaction/CompactionSettings.java,
lines 27-36
> > <https://reviews.apache.org/r/28739/diff/1/?file=783468#file783468line27>
> >
> >     I almost think these should be an enum with a validate() method and a put()
method? Not sure if that would clean up a bunch of code elsewhere or not.

good call, that really reduced redundancy


- kturner


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28739/#review64015
-----------------------------------------------------------


On Dec. 5, 2014, 9:18 p.m., kturner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28739/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 9:18 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3134
>     https://issues.apache.org/jira/browse/ACCUMULO-3134
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Added file selection and output configuration to shell compact command
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/compaction/CompactionSettings.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/strategies/ConfigurableCompactionStrategy.java
PRE-CREATION 
>   shell/src/main/java/org/apache/accumulo/shell/Shell.java 8927ee0 
>   shell/src/main/java/org/apache/accumulo/shell/commands/CompactCommand.java 660630e

>   test/src/test/java/org/apache/accumulo/test/ShellServerIT.java d878c7f 
> 
> Diff: https://reviews.apache.org/r/28739/diff/
> 
> 
> Testing
> -------
> 
> Added an IT that test file selection options on compact command.  IT does not test output
file configuration.
> 
> 
> Thanks,
> 
> kturner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message