accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs" <ctubbsii...@apache.org>
Subject Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser
Date Thu, 04 Dec 2014 22:31:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26507/#review63922
-----------------------------------------------------------

Ship it!


This patch looks good to me. The latest patch incorporates a patch I provided to Jenna, which
makes the PerTableVolumeChooser the default (with the RandomVolumeChooser the default per
table), makes the VolumeChooserEnvironment mandatory, and fixes up Initialize to choose without
per-table configurations (which do not exist during initialize).

- Christopher Tubbs


On Dec. 4, 2014, 4:54 p.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26507/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 4:54 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3177
>     https://issues.apache.org/jira/browse/ACCUMULO-3177
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Added a per table volume chooser that allows tables to be given a specific volume chooser.
 The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives
the preferred volume for a table.  When a table chooser is not specified, or a preferred volume
is not specified then, the default chooser is the RandomVolumeChooser.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java c2c3587 
>   server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java
PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07

>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97

>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java
PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e

>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java 37d5088

>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 6ebbe1e 
>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 670c541 
>   server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java aa37e35 
>   server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java dd3355a

>   server/base/src/main/java/org/apache/accumulo/server/util/RandomizeVolumes.java 82cc855

>   server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java 2c9fe9c

>   server/master/src/main/java/org/apache/accumulo/master/Master.java d5d5145 
>   server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 3d39891

>   server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 247645b

>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 26a6928

>   server/master/src/test/java/org/apache/accumulo/master/tableOps/ImportTableTest.java
31f6bde 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java b7d5b0e

>   server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java
dad9a75 
>   test/src/main/java/org/apache/accumulo/test/FairVolumeChooser.java 9eb0c84 
> 
> Diff: https://reviews.apache.org/r/26507/diff/
> 
> 
> Testing
> -------
> 
> New IT in the patch for ACCUMULO-3178.  Could not test ACCUMULO-3177 without an example
chooser.
> 
> 
> File Attachments
> ----------------
> 
> Diff for 3178
>   https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
> Updated Diff for 3178
>   https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message