accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs" <ctubbsii...@apache.org>
Subject Re: Review Request 27096: ACCUMULO-3178 Create example preferred volumes chooser
Date Thu, 04 Dec 2014 22:25:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27096/#review63921
-----------------------------------------------------------

Ship it!


I think this looks good. It depends on ACCUMULO-3177, but not on ACCUMULO-3176 (as requested
in JIRA), and my feedback has already been squashed in by Jenna. I looked at the test coverage
and it looks pretty comprehensive, and provides a good test case for ACCUMULO-3177 and an
additional useful implementation for a PerTableVolumeChooser.

- Christopher Tubbs


On Dec. 4, 2014, 5:13 p.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27096/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2014, 5:13 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3178
>     https://issues.apache.org/jira/browse/ACCUMULO-3178
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Created example preferred volumes chooser and integration test
> 
> 
> Diffs
> -----
> 
>   server/base/src/main/java/org/apache/accumulo/server/fs/PreferredVolumeChooser.java
PRE-CREATION 
>   server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07

>   test/src/test/java/org/apache/accumulo/test/VolumeChooserIT.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27096/diff/
> 
> 
> Testing
> -------
> 
> New IT
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message