Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6FAB717317 for ; Sat, 8 Nov 2014 17:16:47 +0000 (UTC) Received: (qmail 30294 invoked by uid 500); 8 Nov 2014 17:16:47 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 30269 invoked by uid 500); 8 Nov 2014 17:16:47 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 30256 invoked by uid 99); 8 Nov 2014 17:16:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Nov 2014 17:16:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1D8AE1C09A1; Sat, 8 Nov 2014 17:16:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0158089896937641263==" MIME-Version: 1.0 Subject: Re: Review Request 27654: Add introspection of long running assignments From: "Josh Elser" To: "accumulo" , "Josh Elser" , keith@deenlo.com Date: Sat, 08 Nov 2014 17:16:50 -0000 Message-ID: <20141108171650.10454.29017@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Josh Elser" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/27654/ X-Sender: "Josh Elser" References: <20141108002424.10454.50409@reviews.apache.org> In-Reply-To: <20141108002424.10454.50409@reviews.apache.org> Reply-To: "Josh Elser" X-ReviewRequest-Repository: accumulo --===============0158089896937641263== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Nov. 8, 2014, 12:24 a.m., kturner wrote: > > server/tserver/src/main/java/org/apache/accumulo/tserver/ActiveAssignmentRunnable.java, line 37 > > > > > > should probably be volatile or AtomicRef Ah, good catch. I hadn't thought about that. - Josh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27654/#review60427 ----------------------------------------------------------- On Nov. 7, 2014, 12:59 a.m., Josh Elser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27654/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2014, 12:59 a.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3304 > https://issues.apache.org/jira/browse/ACCUMULO-3304 > > > Repository: accumulo > > > Description > ------- > > Watches assignments and reports when an assignment is running for longer than a configured time. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/conf/Property.java 56f3d9c > server/tserver/pom.xml 3ea50ad > server/tserver/src/main/java/org/apache/accumulo/tserver/ActiveAssignmentRunnable.java PRE-CREATION > server/tserver/src/main/java/org/apache/accumulo/tserver/RunnableStartedAt.java PRE-CREATION > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 94be0bb > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java 935ffeb > > Diff: https://reviews.apache.org/r/27654/diff/ > > > Testing > ------- > > Very minimal. > > > Thanks, > > Josh Elser > > --===============0158089896937641263==--