accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mike Drob <md...@mdrob.com>
Subject Re: [GitHub] accumulo pull request: ACCUMULO-3199 Internal refactor to add Clie...
Date Fri, 21 Nov 2014 03:16:06 GMT
Could you upload this review to reviewboard as well? I have some comments
and would rather avoid triggering an email notification for each one.

On Thu, Nov 20, 2014 at 8:27 PM, ctubbsii <git@git.apache.org> wrote:

> GitHub user ctubbsii opened a pull request:
>
>     https://github.com/apache/accumulo/pull/19
>
>     ACCUMULO-3199 Internal refactor to add ClientContext
>
>       This patch introduces a new ClientContext object that contains
> Credentials,
>       Instance, and Configuration provided from the client API. This new
> object is
>       passed around internally in place of the previous three objects. An
>       AccumuloServerContext is also introduced, which extends the
> ClientContext.
>       Together, these objects ensure the proper configuration,
> credentials, and
>       everything else needed to communicate with other system components
> are
>       available to any RPC-related code.
>
>       These new object types also reduce the need to create multiple
> references to
>       commonly used internal objects (such as HdfsZooInstance and
>       SystemCredentials), and avoids storing information in static fields.
> As a
>       side-effect, this should allow for better testing with mocked
> components.
>
>       This fixes ACCUMULO-3252, and may lay some groundwork for
> ACCUMULO-2589.
>
> You can merge this pull request into a Git repository by running:
>
>     $ git pull https://github.com/ctubbsii/accumulo ACCUMULO-3252
>
> Alternatively you can review and apply these changes as the patch at:
>
>     https://github.com/apache/accumulo/pull/19.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
>     This closes #19
>
> ----
> commit 2355c6379f87f1d891ddfc19a7a4008fe2005631
> Author: Christopher Tubbs <ctubbsii@apache.org>
> Date:   2014-11-21T01:50:55Z
>
>     ACCUMULO-3199 Internal refactor to add ClientContext
>
>       This patch introduces a new ClientContext object that contains
> Credentials,
>       Instance, and Configuration provided from the client API. This new
> object is
>       passed around internally in place of the previous three objects. An
>       AccumuloServerContext is also introduced, which extends the
> ClientContext.
>       Together, these objects ensure the proper configuration,
> credentials, and
>       everything else needed to communicate with other system components
> are
>       available to any RPC-related code.
>
>       These new object types also reduce the need to create multiple
> references to
>       commonly used internal objects (such as HdfsZooInstance and
>       SystemCredentials), and avoids storing information in static fields.
> As a
>       side-effect, this should allow for better testing with mocked
> components.
>
>       This fixes ACCUMULO-3252, and may lay some groundwork for
> ACCUMULO-2589.
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message