accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Re: Review Request 27829: ACCUMULO-1085
Date Mon, 10 Nov 2014 22:52:13 GMT


> On Nov. 10, 2014, 9:38 p.m., Mike Drob wrote:
> > test/src/test/java/org/apache/accumulo/test/AssignmentThreadsIT.java, line 44
> > <https://reviews.apache.org/r/27829/diff/1/?file=757270#file757270line44>
> >
> >     Is this just chars 0-9 & a-f?
> 
> Eric Newton wrote:
>     yes; originally I left the splits as binary, but it was really ugly to read the logs.

a comment saying that would be delightful for those who can't automatically translate hex
to ascii on the fly :)


> On Nov. 10, 2014, 9:38 p.m., Mike Drob wrote:
> > test/src/test/java/org/apache/accumulo/test/AssignmentThreadsIT.java, line 73
> > <https://reviews.apache.org/r/27829/diff/1/?file=757270#file757270line73>
> >
> >     Why go through arithmetic gymnastics instead of just sleep(11000)?
> 
> Eric Newton wrote:
>     Taking the tablets offline probably takes most of the 11 seconds.  This just extends
the wait to make sure that it's at least 11 seconds, but not any more than that.

Why do we have to wait at all? Isn't the wait=true for offline going to be waiting via checking
the current location for all tablets in that table?


- Josh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27829/#review60681
-----------------------------------------------------------


On Nov. 10, 2014, 9:11 p.m., Eric Newton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27829/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2014, 9:11 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Allow for multiple threads to perform assignment, but use only a single thread for recovery
playback
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java f59b654 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 1e81947

>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
ba86522 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java 9490903

>   test/src/test/java/org/apache/accumulo/test/AssignmentThreadsIT.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27829/diff/
> 
> 
> Testing
> -------
> 
> Added an IT that verifies that tablet loading goes faster with more threads.
> 
> 
> Thanks,
> 
> Eric Newton
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message