accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Drob" <md...@mdrob.com>
Subject Re: Review Request 27829: ACCUMULO-1085
Date Mon, 10 Nov 2014 21:38:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27829/#review60681
-----------------------------------------------------------



core/src/main/java/org/apache/accumulo/core/conf/Property.java
<https://reviews.apache.org/r/27829/#comment102063>

    Add to the description that this does not affect recovery.



server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
<https://reviews.apache.org/r/27829/#comment102060>

    I don't see any other classes being modified to account for this potential InterruptedException.
I see that we catch Throwable in calling code in Tablet L644, but should we also be resetting
the interrupted state in that case?



server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
<https://reviews.apache.org/r/27829/#comment102058>

    Why are we using a Semaphore over just making the method synchronized? It would make sense
if there was some other code section also checking on the semaphore, but I don't see it.



test/src/test/java/org/apache/accumulo/test/AssignmentThreadsIT.java
<https://reviews.apache.org/r/27829/#comment102062>

    Plkease add a test that only one recovery will happen at a time.



test/src/test/java/org/apache/accumulo/test/AssignmentThreadsIT.java
<https://reviews.apache.org/r/27829/#comment102061>

    nit: more descriptive test method name please



test/src/test/java/org/apache/accumulo/test/AssignmentThreadsIT.java
<https://reviews.apache.org/r/27829/#comment102057>

    Is this just chars 0-9 & a-f?



test/src/test/java/org/apache/accumulo/test/AssignmentThreadsIT.java
<https://reviews.apache.org/r/27829/#comment102056>

    Why go through arithmetic gymnastics instead of just sleep(11000)?


- Mike Drob


On Nov. 10, 2014, 9:11 p.m., Eric Newton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27829/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2014, 9:11 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Allow for multiple threads to perform assignment, but use only a single thread for recovery
playback
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java f59b654 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 1e81947

>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
ba86522 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java 9490903

>   test/src/test/java/org/apache/accumulo/test/AssignmentThreadsIT.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/27829/diff/
> 
> 
> Testing
> -------
> 
> Added an IT that verifies that tablet loading goes faster with more threads.
> 
> 
> Thanks,
> 
> Eric Newton
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message