accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3321 Logging ThriftScanner excepti...
Date Mon, 10 Nov 2014 05:24:58 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/18#discussion_r20067167
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/ThriftScanner.java ---
    @@ -115,12 +115,12 @@ public static boolean getBatchFromServer(Instance instance, Credentials
credenti
         } catch (TApplicationException tae) {
           throw new AccumuloServerException(server, tae);
         } catch (TooManyFilesException e) {
    -      log.debug("Tablet (" + extent + ") has too many files " + server + " : " + e);
    +      log.warn("Tablet (" + extent + ") has too many files " + server + " : " + e);
         } catch (ThriftSecurityException e) {
           log.warn("Security Violation in scan request to " + server + ": " + e);
           throw new AccumuloSecurityException(e.user, e.code, e);
         } catch (TException e) {
    -      log.debug("Error getting transport to " + server + " : " + e);
    +      log.warn("Error getting transport to " + server + " : " + e);
    --- End diff --
    
    This is tricky. In the case that a tserver fails, this would cause logging on the client.
Ideally, the system will recover from a tserver failure and the client wouldn't even have
to know that a failure happened. Might it make more sense to leave this at debug for the first
N occurrences for a server and then elevate it to warn at the N+1th time?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message