accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request 27654: Add introspection of long running assignments
Date Thu, 06 Nov 2014 17:47:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27654/#review60185
-----------------------------------------------------------



core/src/main/java/org/apache/accumulo/core/conf/Property.java
<https://reviews.apache.org/r/27654/#comment101520>

    I think this default may be too low for reasons you mentioned on irc (like a walog recovery
taking a while).  I am thinking 5 or 10 min would be better.  We don't want people to ignore
the warning, if it happens more than it should.



server/tserver/src/main/java/org/apache/accumulo/tserver/ActiveAssignmentRunnable.java
<https://reviews.apache.org/r/27654/#comment101523>

    It seems LoggingRunnable's run method is never executed?



server/tserver/src/main/java/org/apache/accumulo/tserver/ActiveAssignmentRunnable.java
<https://reviews.apache.org/r/27654/#comment101538>

    Since this code is outside of try, if it ever throws an exception then extent will not
be removed from map.



server/tserver/src/main/java/org/apache/accumulo/tserver/ActiveAssignmentRunnable.java
<https://reviews.apache.org/r/27654/#comment101528>

    Could create an exception like the compaction watcher code and let the logging framework
do what it wants w/ the exception.
    
    https://github.com/apache/accumulo/blob/1.6.1/server/tserver/src/main/java/org/apache/accumulo/tserver/CompactionWatcher.java#L91



server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
<https://reviews.apache.org/r/27654/#comment101535>

    why have two maps?



server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
<https://reviews.apache.org/r/27654/#comment101542>

    why make these final?  and locals outside of loop not?



server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
<https://reviews.apache.org/r/27654/#comment101521>

    15 seconds?



server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
<https://reviews.apache.org/r/27654/#comment101533>

    The compaction code remembers when it logged an exception and does not do it again.  
It also logs a message if the compaction becomes unstuck.  An advantage I thought of w/ repeatedly
logging, is that you could see the stack trace changing (or not).
    
    The stack trace is  a possible trace.  By the time logging happens, the assignment could
have completed and the thread could have moved on to other things.


- kturner


On Nov. 6, 2014, 12:58 a.m., Josh Elser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27654/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 12:58 a.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3304
>     https://issues.apache.org/jira/browse/ACCUMULO-3304
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Watches assignments and reports when an assignment is running for longer than a configured
time.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java 56f3d9c 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/ActiveAssignmentRunnable.java
PRE-CREATION 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/RunnableStartedAt.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 94be0bb

>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
935ffeb 
> 
> Diff: https://reviews.apache.org/r/27654/diff/
> 
> 
> Testing
> -------
> 
> Very minimal.
> 
> 
> Thanks,
> 
> Josh Elser
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message