Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 447AA173A2 for ; Mon, 6 Oct 2014 20:54:25 +0000 (UTC) Received: (qmail 93201 invoked by uid 500); 6 Oct 2014 20:54:25 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 93157 invoked by uid 500); 6 Oct 2014 20:54:25 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 93144 invoked by uid 99); 6 Oct 2014 20:54:25 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Oct 2014 20:54:25 +0000 Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 21C6F1A0692 for ; Mon, 6 Oct 2014 20:54:23 +0000 (UTC) Received: by mail-wi0-f172.google.com with SMTP id n3so5883790wiv.17 for ; Mon, 06 Oct 2014 13:54:22 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.180.75.210 with SMTP id e18mr22888655wiw.6.1412628862067; Mon, 06 Oct 2014 13:54:22 -0700 (PDT) Received: by 10.27.79.149 with HTTP; Mon, 6 Oct 2014 13:54:22 -0700 (PDT) In-Reply-To: References: Date: Mon, 6 Oct 2014 16:54:22 -0400 Message-ID: Subject: Re: Deprecation removal for 1.7.0 From: Christopher To: Accumulo Dev List Content-Type: multipart/alternative; boundary=f46d0438906785ecd30504c749b3 --f46d0438906785ecd30504c749b3 Content-Type: text/plain; charset=UTF-8 The main thing I'm looking at which is causing problems for me is the instance.getConfiguration() stuff. It was never well defined, usually didn't work or do what was expected of it, and is still being leveraged (incorrectly) by new code (replication, for instance, and I've already informed Josh), because of ServerConfigurationUtil.getConfiguration(Instance instance). It wasn't formally deprecated until 1.6.0, though. Aside from that, everything else is just a nice cleanup. A somewhat exhaustive list of what I was looking at was: Scanner timeout options extra batchwriter/batchdeleter factory methods some junk in MutationsRejectedException extra ZooKeeperInstance constructors securityOperations stuff from 1.5 extra getSplits and flush in tableOperations Constants.NO_AUTHS KeyExtents.getKeyExtentsForRange an extra Value constructor which copies from a ByteBuffer iterators that moved packages in 1.4 some protected getters in the mapred stuff unused RangeInputSplit in InputFormatBase LogFileKey/LogFileValue (old version) You can review the expected changes at https://github.com/ctubbsii/accumulo/tree/ACCUMULO-3197 (in two commits, one for instance stuff, the other for aggregators and everything else). -- Christopher L Tubbs II http://gravatar.com/ctubbsii On Mon, Oct 6, 2014 at 4:11 PM, Sean Busbey wrote: > No objection to removing aggregators. > > If anything first deprecated in 1.5 has managed to live this long in 1.7 > I'd like to keep it so folks have an easier time getting off of 1.5 when we > EOL it. But I realize some things have probably already been removed. > > On Mon, Oct 6, 2014 at 3:00 PM, Christopher wrote: > > > Re: ACCUMULO-3197 > > > > First: > > Any objections to finally removing Aggregators in 1.7.0? > > They've been deprecated in favor of Combiners since 1.4. > > > > Second: > > Is there any API deprecated in 1.6.x or earlier that you really want > > preserved in 1.7.0? > > (I know we need to keep INSTANCE_DFS_{URI,DIR} properties for volume > > upgrades, at least.) > > > > -- > > Christopher L Tubbs II > > http://gravatar.com/ctubbsii > > > > > > -- > Sean > --f46d0438906785ecd30504c749b3--