Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 669A717B84 for ; Wed, 8 Oct 2014 20:49:36 +0000 (UTC) Received: (qmail 30398 invoked by uid 500); 8 Oct 2014 20:49:35 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 30364 invoked by uid 500); 8 Oct 2014 20:49:35 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 30108 invoked by uid 99); 8 Oct 2014 20:49:35 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Oct 2014 20:49:35 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of mdrob@cloudera.com designates 209.85.218.48 as permitted sender) Received: from [209.85.218.48] (HELO mail-oi0-f48.google.com) (209.85.218.48) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Oct 2014 20:49:10 +0000 Received: by mail-oi0-f48.google.com with SMTP id g201so8857043oib.21 for ; Wed, 08 Oct 2014 13:49:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=4KYGutLoXC6h54Ud/BytgHaeE8xzb06l5UviNUs02mo=; b=CiLgdJI73KgPIAOuHZbbQRfy5W/MYO7LfC/rzYZGxtH0GD3qUxjWGng7mbN9zGYD+m sXmt6Q13wzrnLkf1o+U6tq6tAjzoAzJEAcDaEnpkyqPDlCorW7KFQQAatqMRoGyQXWv8 GfAtqOtu0Wmgvu5s76/w5rpHaHzNjcWq7h7s7xKlLRYvKlrwlSemdPU2PRFZTUfgqVFP 6wndIrkeLcAOy+UlsddZoVHYilFl4pNMjxh/O7WwhqPRtaJWcxwlzRvyHtxR1gmxAY/C U1JaQq4jwZeZXjuXQNYh9ngu41xd1D8i0T0uV0ser77tDY5353hVMg0o+VamD959eVsF raYQ== X-Gm-Message-State: ALoCoQmzAPLdmuJGa8yVSU+nPQ/K46oEVWbgeHv3hMHaYMXkCrpmTgS71NgE4ZlCo0fF7Yq4ChyT X-Received: by 10.60.47.100 with SMTP id c4mr2128496oen.58.1412801348870; Wed, 08 Oct 2014 13:49:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.222.105 with HTTP; Wed, 8 Oct 2014 13:48:47 -0700 (PDT) In-Reply-To: References: <20141006214223.GA7997@ll.mit.edu> From: Mike Drob Date: Wed, 8 Oct 2014 15:48:47 -0500 Message-ID: Subject: Re: Deprecation removal for 1.7.0 To: Accumulo Dev List Content-Type: multipart/alternative; boundary=001a11c20b2c89bb2b0504ef7220 X-Virus-Checked: Checked by ClamAV on apache.org --001a11c20b2c89bb2b0504ef7220 Content-Type: text/plain; charset=UTF-8 Applications that worked with Accumulo 1.4 may or may not work with 1.6 already (we've made a lot of changes to the InputFormat, for example) so trying to promise compatibility with 2.0 sounds like a very losing battle. On Wed, Oct 8, 2014 at 3:44 PM, Keith Turner wrote: > On Tue, Oct 7, 2014 at 3:03 PM, Bill Havanki > wrote: > > > I took a look at Christopher's commits for ACCUMULO-3197 and they all > look > > fine to me. Any other reviewers may like to add "?w=1" to the URL for > each > > commit to ignore whitespace-only changes in the view, e.g.: > > > > > > > https://github.com/ctubbsii/accumulo/commit/dc1332b5fb5f358f3fff432a1a0fef4f56c1628e > > *?w=1* > > > > Going forward, it'd be nice to have a rule of thumb for how long a > > deprecated item will linger: some possibilities: > > > > - 2 minor releases or the next major release, whichever comes first > > - always until the next major release (this may make sense starting with > > 2.0.0) > > > > I like the idea of a tool to find use of deprecated calls; it appears > that > > Eclipse and Sonar can do that: > > > > > > > http://stackoverflow.com/questions/14490021/scanning-code-base-for-use-of-deprecated-methods > > > > Overall, +1 to removing deprecations from 1.4 and earlier. > > > > So this in effect making the statement that Accumulo apps that worked w/ > 1.4 may not work w/ 2.0.0. Is that what we want? If this would cause > someone to not Adopt 2.0.0, is that what we would want? Do we want to be > able to say that if your app worked w/ 1.4, it will work with 2.0.0? If > so, 2.0.0 does not have to exist forever. Eventually we can release 3.0.0 > and break 1.4 apps. > > > > > > > Bill > > > > > > On Mon, Oct 6, 2014 at 11:18 PM, Christopher > wrote: > > > > > On Mon, Oct 6, 2014 at 9:45 PM, Adam Fuchs wrote: > > > > > > > So, I think we can make a general argument to set policy, and when > > > removing > > > > a specific method we should make a specific argument. Personally, I > > would > > > > set the bar at identifying the specific harm cause by the retention > of > > > the > > > > method, as well as polling the community and considering objections. > > > > > > > > Christopher, you made an argument about people misunderstanding the > > > > semantics of the method and using it incorrectly. Is that not solved > by > > > > just deprecating the method? > > > > > > > > > > > Clearly no, since mistakes are still occurring in 1.7.0-SNAPSHOT and it > > was > > > deprecated in 1.6.0. Further, it was hard to notice because: > > > > > > 1) it's the only way to currently get that information from the API to > > the > > > RPC layer (see ACCUMULO-3199) > > > (In my proposed commit[1], I offer a temporary workaround which > involves > > > better naming, and limits the API to the ZooKeeperInstance only) > > > 2) the use of the method occurred in a somewhat badly named utility > > method > > > which suppressed deprecation warnings > > > > > > Until ACCUMULO-3199 is fixed to address the shortcoming of being able > to > > > get the user-provided client RPC config to the RPC layer, this method > is > > > going to be prone to abuse. > > > > > > [1] https://github.com/ctubbsii/accumulo/commit/52806b6?diff=split > > > > > > -- > > > Christopher L Tubbs II > > > http://gravatar.com/ctubbsii > > > > > > > > > > > -- > > // Bill Havanki > > // Solutions Architect, Cloudera Govt Solutions > > // 443.686.9283 > > > --001a11c20b2c89bb2b0504ef7220--