Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C88D9176B7 for ; Tue, 28 Oct 2014 14:12:28 +0000 (UTC) Received: (qmail 97919 invoked by uid 500); 28 Oct 2014 14:12:28 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 97875 invoked by uid 500); 28 Oct 2014 14:12:28 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 97852 invoked by uid 99); 28 Oct 2014 14:12:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Oct 2014 14:12:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BD6751DF805; Tue, 28 Oct 2014 14:12:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4829274966356918751==" MIME-Version: 1.0 Subject: Re: Review Request 26507: ACCUMULO-3177 Create a per table volume chooser and ACCUMULO-3178 Create example preferred volumes chooser From: "Josh Elser" To: "accumulo" , "Josh Elser" , "Jenna Huston" Date: Tue, 28 Oct 2014 14:12:32 -0000 Message-ID: <20141028141232.7137.30210@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Josh Elser" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/26507/ X-Sender: "Josh Elser" References: <20141028124846.7138.75355@reviews.apache.org> In-Reply-To: <20141028124846.7138.75355@reviews.apache.org> Reply-To: "Josh Elser" X-ReviewRequest-Repository: accumulo --===============4829274966356918751== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26507/#review58802 ----------------------------------------------------------- Ship it! Ship It! - Josh Elser On Oct. 28, 2014, 12:48 p.m., Jenna Huston wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26507/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 12:48 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3177 > https://issues.apache.org/jira/browse/ACCUMULO-3177 > > > Repository: accumulo > > > Description > ------- > > Added a per table volume chooser that allows tables to be given a specific volume chooser. The second patch, ACCUMULO-3178, adds an example, a preferred volume chooser which gives the preferred volume for a table. When a table chooser is not specified, or a preferred volume is not specified then, the default chooser is the RandomVolumeChooser. > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/conf/Property.java ad4fe92 > server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java PRE-CREATION > server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java 2760b07 > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java 8713c97 > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooserEnvironment.java PRE-CREATION > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManager.java cbfdb5e > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeManagerImpl.java e4a42dc > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 82b77ee > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 602f214 > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 > server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java 5f34279 > server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 > server/master/src/main/java/org/apache/accumulo/master/Master.java 42495f4 > server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 > server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java f56c1e2 > server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java 44ca898 > server/master/src/test/java/org/apache/accumulo/master/tableOps/ImportTableTest.java 31f6bde > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java e923ebc > server/tserver/src/test/java/org/apache/accumulo/tserver/TabletServerSyncCheckTest.java dad9a75 > > Diff: https://reviews.apache.org/r/26507/diff/ > > > Testing > ------- > > New IT in the patch for ACCUMULO-3178. Could not test ACCUMULO-3177 without an example chooser. > > > File Attachments > ---------------- > > Diff for 3178 > https://reviews.apache.org/media/uploaded/files/2014/10/09/07d2693e-9acc-438b-9b13-667bde467590__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch > Updated Diff for 3178 > https://reviews.apache.org/media/uploaded/files/2014/10/14/2b5aa6b9-92d0-4938-bcf9-2021cd0212ee__0001-ACCUMULO-3178-Create-example-preferred-volumes-choos.patch > > > Thanks, > > Jenna Huston > > --===============4829274966356918751==--