Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Content-Type: multipart/alternative;
 boundary="===============3975986057532590213=="
MIME-Version: 1.0
Subject: Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't
 always comply with implied API contract
From: "Sean Busbey" <sean@manvsbeard.com>
To: "Sean Busbey" <sean@manvsbeard.com>, "accumulo" <dev@accumulo.apache.org>,
 "Jenna Huston" <jenna.huston22@gmail.com>
Date: Fri, 24 Oct 2014 02:38:17 -0000
Message-ID: <20141024023817.1282.25764@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Sean Busbey" <noreply@reviews.apache.org>
References: <20141023171420.1283.17824@reviews.apache.org>
In-Reply-To: <20141023171420.1283.17824@reviews.apache.org>
Reply-To: "Sean Busbey" <sean@manvsbeard.com>

--===============3975986057532590213==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26514/#review58226
-----------------------------------------------------------


server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java
<https://reviews.apache.org/r/26514/#comment99172>

    First we use ServerConstants.TABLE_DIR to validate the input and then we use Constants.HDFS_TABLES_DIR to set up the new location.
    
    Why the difference?
    
    It's hard for me to tell if this is expected behavior because there isn't a method level javadoc.


server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java
<https://reviews.apache.org/r/26514/#comment99179>

    Either use nested Path(parent, child) or replace the literal '/' with Path.SEPARATOR


- Sean Busbey


On Oct. 23, 2014, 5:14 p.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26514/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 5:14 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3181
>     https://issues.apache.org/jira/browse/ACCUMULO-3181
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Delayed adding paths to volume options until after a volume is chosen.
> 
> 
> Diffs
> -----
> 
>   server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 10a864c 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java c87074b 
>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java fcecc37 
>   server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 
>   server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java f908d25 
>   server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113 
>   server/master/src/main/java/org/apache/accumulo/master/Master.java f894afc 
>   server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 5b64053 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 2bd0b47 
> 
> Diff: https://reviews.apache.org/r/26514/diff/
> 
> 
> Testing
> -------
> 
> Ran existing VolumeIT.
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>


--===============3975986057532590213==--