Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4EBDB17E63 for ; Mon, 20 Oct 2014 19:00:21 +0000 (UTC) Received: (qmail 58124 invoked by uid 500); 20 Oct 2014 19:00:21 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 58081 invoked by uid 500); 20 Oct 2014 19:00:21 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 58068 invoked by uid 99); 20 Oct 2014 19:00:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Oct 2014 19:00:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0D8141DB868; Mon, 20 Oct 2014 19:00:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8846052639116683753==" MIME-Version: 1.0 Subject: Re: Review Request 26943: Changes to ZK for implicit retry handling From: "Eric Newton" To: "Eric Newton" , "accumulo" , "Josh Elser" Date: Mon, 20 Oct 2014 19:00:26 -0000 Message-ID: <20141020190026.1282.10938@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Eric Newton" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/26943/ X-Sender: "Eric Newton" References: <20141020162830.1283.59841@reviews.apache.org> In-Reply-To: <20141020162830.1283.59841@reviews.apache.org> Reply-To: "Eric Newton" X-ReviewRequest-Repository: accumulo --===============8846052639116683753== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26943/#review57379 ----------------------------------------------------------- fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCache.java nit: spelling "wil" fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooUtil.java maybe add hashCode and equals? fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooUtil.java nit: braces - Eric Newton On Oct. 20, 2014, 4:28 p.m., Josh Elser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26943/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 4:28 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3242 > https://issues.apache.org/jira/browse/ACCUMULO-3242 > > > Repository: accumulo > > > Description > ------- > > We didn't do some things correctly WRT zookeeper retries. Attempt to make it better. Made a review in case people want to give some feedback > > > Diffs > ----- > > fate/src/main/java/org/apache/accumulo/fate/zookeeper/IZooReaderWriter.java afc2250 > fate/src/main/java/org/apache/accumulo/fate/zookeeper/Retry.java 4a37172 > fate/src/main/java/org/apache/accumulo/fate/zookeeper/RetryFactory.java 3fcb738 > fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCache.java d9eb243 > fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooReader.java 994f395 > fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooReaderWriter.java b29b88a > fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooUtil.java e0d8831 > fate/src/test/java/org/apache/accumulo/fate/zookeeper/RetryTest.java PRE-CREATION > fate/src/test/java/org/apache/accumulo/fate/zookeeper/ZooReaderWriterTest.java PRE-CREATION > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 5cbffc3 > server/base/src/main/java/org/apache/accumulo/server/security/handler/ZKPermHandler.java 3cac2e9 > > Diff: https://reviews.apache.org/r/26943/diff/ > > > Testing > ------- > > UTs/ITs > > > Thanks, > > Josh Elser > > --===============8846052639116683753==--