Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
Content-Type: multipart/alternative;
 boundary="===============1266829397847761649=="
MIME-Version: 1.0
Subject: Re: Review Request 23397: ACCUMULO-2984 Support Running MAC against a
 standard instance
From: "John Vines" <vines@apache.org>
To: "John Vines" <vines@apache.org>, "accumulo" <dev@accumulo.apache.org>,
 keith@deenlo.com
Date: Wed, 15 Oct 2014 22:08:41 -0000
Message-ID: <20141015220841.24413.52332@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "John Vines" <noreply@reviews.apache.org>
References: <20140715185837.24005.1347@reviews.apache.org>
In-Reply-To: <20140715185837.24005.1347@reviews.apache.org>
Reply-To: "John Vines" <vines@apache.org>

--===============1266829397847761649==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On July 15, 2014, 6:58 p.m., kturner wrote:
> > minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java, line 259
> > <https://reviews.apache.org/r/23397/diff/4/?file=628112#file628112line259>
> >
> >     Would be nice to document how this method relates to setSiteConfig() and setZookeeperPort() 
> >     
> >     I assume if calling this and setZookeeperPort() that the zookeeper port set would be ignored, but I have not look.  
> >     
> >     Calling useExistingInstance and then setSiteConfig() could gum things up.

Addressed with strict checking


> On July 15, 2014, 6:58 p.m., kturner wrote:
> > minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java, line 267
> > <https://reviews.apache.org/r/23397/diff/4/?file=628112#file628112line267>
> >
> >     A test to prevent regressions would be really nice.  Might be able to start a mini instance, stop it, use internal exec methods to start a zookeeper, and then point another mac to the old mini instance.

I'm gonna be blunt - this is really really hard and I think it can be punted to a ticket for future work


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23397/#review47792
-----------------------------------------------------------


On July 10, 2014, 10:48 p.m., John Vines wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23397/
> -----------------------------------------------------------
> 
> (Updated July 10, 2014, 10:48 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2984
>     https://issues.apache.org/jira/browse/ACCUMULO-2984
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Adds a change to SiteConfiguration to allow external setting of the xml configuration file.
> Adds a single method to MiniAccumuloConfig which allows a user to point to accumulo-site.xml and HADOOP_CONF_DIR to use for pulling out requisite instance information
> Clusters configurations into those required to run inside a MAC-sized footprint and those which are for arbitrary naming schemes for MAC
> Provides flagging to prevent uneccessary folder creation
> Provides flagging to prevent running zookeeper and initializing
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/conf/SiteConfiguration.java 4c7d95e 
>   minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloCluster.java 50bb14a 
>   minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java be80f85 
>   minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java 977968e 
>   minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloConfigImpl.java 337eda0 
>   server/base/src/main/java/org/apache/accumulo/server/util/AccumuloStatus.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23397/diff/
> 
> 
> Testing
> -------
> 
> Ran the following test code-
> public class TestMACWithRealInstance {
>   public static void main(String args[]) throws IOException, AccumuloException, AccumuloSecurityException, TableExistsException, InterruptedException {
>     MiniAccumuloConfig macConfig = new MiniAccumuloConfig(new File("/tmp/mac"), "secret");
>     macConfig.setNumTservers(2);
>     macConfig.setMemory(ServerType.TABLET_SERVER, 2, MemoryUnit.GIGABYTE);
>     macConfig.useExistingInstance(new File("/usr/lib/accumulo/conf/accumulo-site.xml"), new File("/usr/lib/hadoop/conf"));
>     MiniAccumuloCluster mac = new MiniAccumuloCluster(macConfig);
>     mac.start();
>     System.out.println("Started");
>     mac.getConnector("root", "secret").tableOperations().create("macCreated");
>     System.out.println("Stopping");
>     mac.stop();
>     System.out.println("Stopped");
>   }
> }
> Which runs fine, except stopping issues which seem to be related to ACCUMULO-2985
> 
> After running this, I validated that the table was created in the real accumulo instance via zkCli
> 
> 
> Thanks,
> 
> John Vines
> 
>


--===============1266829397847761649==--