Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8C8FB174F5 for ; Wed, 8 Oct 2014 18:28:09 +0000 (UTC) Received: (qmail 87367 invoked by uid 500); 8 Oct 2014 18:28:09 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 87321 invoked by uid 500); 8 Oct 2014 18:28:09 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 87293 invoked by uid 99); 8 Oct 2014 18:28:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Oct 2014 18:28:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 401021DDD55; Wed, 8 Oct 2014 18:28:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8451868923420077582==" MIME-Version: 1.0 Subject: Re: Review Request 26188: ACCUMULO-3176 Add ability to create a table with user specified initial properties From: "Jenna Huston" To: "Christopher Tubbs" , "accumulo" , "Josh Elser" , keith@deenlo.com, "Jenna Huston" Date: Wed, 08 Oct 2014 18:28:05 -0000 Message-ID: <20141008182805.24817.92977@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jenna Huston" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/26188/ X-Sender: "Jenna Huston" References: <20141008152137.24818.59414@reviews.apache.org> In-Reply-To: <20141008152137.24818.59414@reviews.apache.org> Reply-To: "Jenna Huston" X-ReviewRequest-Repository: accumulo --===============8451868923420077582== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26188/ ----------------------------------------------------------- (Updated Oct. 8, 2014, 6:28 p.m.) Review request for accumulo. Bugs: ACCUMULO-3176 https://issues.apache.org/jira/browse/ACCUMULO-3176 Repository: accumulo Description ------- Gives the ability to add properties to tables before they are initialized. Therefore these properties will take effect before the default tablet is created. We create a NewTableConfiguration class and send that in the create method as opposed to adding another method. Diffs (updated) ----- core/src/main/java/org/apache/accumulo/core/client/NewTableConfiguration.java PRE-CREATION core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 97f538d core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java e46b9c9 core/src/main/java/org/apache/accumulo/core/client/mock/MockAccumulo.java 32dbb28 core/src/main/java/org/apache/accumulo/core/client/mock/MockTable.java 35cbdd2 core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 08750fe core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java 02838ed proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java a778add shell/src/main/java/org/apache/accumulo/shell/commands/CreateTableCommand.java 81b39d2 test/src/test/java/org/apache/accumulo/test/CreateTableWithNewTableConfigIT.java PRE-CREATION test/src/test/java/org/apache/accumulo/test/ShellServerIT.java 5a068af Diff: https://reviews.apache.org/r/26188/diff/ Testing ------- New IT, ran unit test and integration tests Thanks, Jenna Huston --===============8451868923420077582==--