Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7265C17ED8 for ; Wed, 1 Oct 2014 15:49:29 +0000 (UTC) Received: (qmail 17799 invoked by uid 500); 1 Oct 2014 15:49:28 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 17762 invoked by uid 500); 1 Oct 2014 15:49:28 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 17749 invoked by uid 99); 1 Oct 2014 15:49:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Oct 2014 15:49:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 71BCB1DDA8B; Wed, 1 Oct 2014 15:49:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2686680352550440751==" MIME-Version: 1.0 Subject: Re: Review Request 26153: ACCUMULO-3182 WAL recovery on empty files doesn't fail From: "Josh Elser" To: "accumulo" , "Josh Elser" , keith@deenlo.com Date: Wed, 01 Oct 2014 15:49:25 -0000 Message-ID: <20141001154925.19177.90879@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Josh Elser" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/26153/ X-Sender: "Josh Elser" References: <20141001010226.19177.22485@reviews.apache.org> In-Reply-To: <20141001010226.19177.22485@reviews.apache.org> Reply-To: "Josh Elser" X-ReviewRequest-Repository: accumulo --===============2686680352550440751== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 1, 2014, 1:02 a.m., kturner wrote: > > test/src/test/java/org/apache/accumulo/test/MissingWalHeaderCompletesRecoveryIT.java, line 196 > > > > > > Could use the following here... > > > > MetadataSchema.TabletsSection.getRow(tableId, null); Ah, thanks! I missed that helpful method. > On Oct. 1, 2014, 1:02 a.m., kturner wrote: > > test/src/test/java/org/apache/accumulo/test/MissingWalHeaderCompletesRecoveryIT.java, line 216 > > > > > > this sleep should not be needed I agree with you, but I still see https://issues.apache.org/jira/browse/ACCUMULO-2964 infrequently. Offline'ing the table should actually preclude the unexplained Thrift exception (if I'm right in that it's tied to the tserver restart) and it would actually make the test more generally usable. - Josh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26153/#review55044 ----------------------------------------------------------- On Sept. 30, 2014, 11:01 p.m., Josh Elser wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26153/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2014, 11:01 p.m.) > > > Review request for accumulo. > > > Bugs: ACCUMULO-3182 > https://issues.apache.org/jira/browse/ACCUMULO-3182 > > > Repository: accumulo > > > Description > ------- > > Ensures that a WAL that was empty or missing a complete header (due to tservers dying before it could happen) can be successfully recovered (by assuming that the lack of a complete header means there is no data to recover). Currently against master, will pull back to 1.5 and merge forward since it likely affects all branches. > > > Diffs > ----- > > server/base/src/main/java/org/apache/accumulo/server/log/SortedLogState.java PRE-CREATION > server/master/src/main/java/org/apache/accumulo/master/recovery/RecoveryManager.java 791aec8 > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java b4fbfed > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 8de2b25 > server/tserver/src/main/java/org/apache/accumulo/tserver/log/LogSorter.java 4badefa > server/tserver/src/main/java/org/apache/accumulo/tserver/log/MultiReader.java 541f075 > server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogReader.java 681fbd3 > server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java 416a86e > server/tserver/src/test/java/org/apache/accumulo/tserver/log/MultiReaderTest.java a79e77e > server/tserver/src/test/java/org/apache/accumulo/tserver/log/SortedLogRecoveryTest.java fffa15e > server/tserver/src/test/java/org/apache/accumulo/tserver/log/TestUpgradePathForWALogs.java f01ee10 > test/src/test/java/org/apache/accumulo/test/MissingWalHeaderCompletesRecoveryIT.java PRE-CREATION > > Diff: https://reviews.apache.org/r/26153/diff/ > > > Testing > ------- > > New IT, ran UTs and ITs. > > > Thanks, > > Josh Elser > > --===============2686680352550440751==--