accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher <ctubb...@apache.org>
Subject Re: New Defects reported by Coverity Scan for Accumulo
Date Thu, 30 Oct 2014 02:22:26 GMT
Are these issues ones that are not already possible to find with FindBugs?
It seems to me that some of them probably do overlap with FindBugs. I
wouldn't mind bumping up the sensitivity of FindBugs in the build if we can
resolve the outstanding issues by doing so, as we go, to prevent new issues
from being introduced.


--
Christopher L Tubbs II
http://gravatar.com/ctubbsii

On Wed, Oct 29, 2014 at 8:07 PM, Josh Elser <josh.elser@gmail.com> wrote:

> Do we want to set up Coverity to send these types of messages to dev@a.a.o
> automatically?
>
> -------- Original Message --------
> Subject: New Defects reported by Coverity Scan for Accumulo
> Date: Wed, 29 Oct 2014 16:59:37 -0700
> From: scan-admin@coverity.com
> To: josh.elser@gmail.com
>
>
> Hi,
>
> Please find the latest report on new defect(s) introduced to Accumulo
> found with Coverity Scan.
>
> 4 new defect(s) introduced to Accumulo found with Coverity Scan.
> 18 defect(s), reported by Coverity Scan earlier, were marked fixed in the
> recent build analyzed by Coverity Scan.
>
> New defect(s) Reported-by: Coverity Scan
> Showing 4 of 4 defect(s)
>
>
> ** CID 1250066:  Unguarded read  (GUARDED_BY_VIOLATION)
> /minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java:
> 852 in org.apache.accumulo.minicluster.impl.MiniAccumuloClusterImpl.
> getMiniDfs()()
>
> ** CID 1250064:  Arguments in wrong order  (SWAPPED_ARGUMENTS)
>
> ** CID 1250062:  Dm: Dubious method used  (FB.DM_DEFAULT_ENCODING)
> /server/base/src/main/java/org/apache/accumulo/server/util/RandomizeVolumes.java:
> 109 in org.apache.accumulo.server.util.RandomizeVolumes.
> randomize(org.apache.accumulo.core.client.Connector, java.lang.String)()
>
> ** CID 1250058:  DLS: Dead local store  (FB.DLS_DEAD_LOCAL_STORE)
> /server/tserver/src/main/java/org/apache/accumulo/tserver/log/LogSorter.java:
> 176 in org.apache.accumulo.tserver.log.LogSorter$LogProcessor.writeBuffer(java.lang.String,
> java.util.List, int)()
>
>
> ____________________________________________________________
> ____________________________________________
> *** CID 1250066:  Unguarded read  (GUARDED_BY_VIOLATION)
> /minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java:
> 852 in org.apache.accumulo.minicluster.impl.MiniAccumuloClusterImpl.
> getMiniDfs()()
> 846           }
> 847         }
> 848         return stats;
> 849       }
> 850
> 851       public MiniDFSCluster getMiniDfs() {
>
>>     CID 1250066:  Unguarded read  (GUARDED_BY_VIOLATION)
>>>>     Accessing "this.miniDFS" without holding lock
>>>> "MiniAccumuloClusterImpl.this". Elsewhere, "org.apache.accumulo.
>>>> minicluster.impl.MiniAccumuloClusterImpl.miniDFS" is accessed with
>>>> "MiniAccumuloClusterImpl.this" held 3 out of 4 times.
>>>>
>>> 852         return this.miniDFS;
> 853       }
>
> ____________________________________________________________
> ____________________________________________
> *** CID 1250064:  Arguments in wrong order  (SWAPPED_ARGUMENTS)
> /fate/src/main/java/org/apache/accumulo/fate/zookeeper/RetryFactory.java:
> 36 in org.apache.accumulo.fate.zookeeper.RetryFactory.create()()
> 30         this.startWait = startWait;
> 31         this.maxWait = maxWait;
> 32         this.waitIncrement = waitIncrement;
> 33       }
> 34
> 35       public Retry create() {
>
>>     CID 1250064:  Arguments in wrong order  (SWAPPED_ARGUMENTS)
>>>>     The positions of arguments in the constructor for
>>>> "org.apache.accumulo.fate.zookeeper.Retry" do not match the ordering
>>>> of the parameters:
>>>>
>>> * "maxWait" is passed to "waitIncrement"
> * "waitIncrement" is passed to "maxWait"
> 36         return new Retry(maxRetries, startWait, maxWait, waitIncrement);
> 37       }
>
> ____________________________________________________________
> ____________________________________________
> *** CID 1250062:  Dm: Dubious method used  (FB.DM_DEFAULT_ENCODING)
> /server/base/src/main/java/org/apache/accumulo/server/util/RandomizeVolumes.java:
> 109 in org.apache.accumulo.server.util.RandomizeVolumes.
> randomize(org.apache.accumulo.core.client.Connector, java.lang.String)()
> 103             directory = oldLocation.substring(Path.
> SEPARATOR.length());
> 104           }
> 105           Key key = entry.getKey();
> 106           Mutation m = new Mutation(key.getRow());
> 107
> 108           String newLocation = vm.choose(ServerConstants.getBaseUris())
> + Path.SEPARATOR + ServerConstants.TABLE_DIR + Path.SEPARATOR + tableId +
> Path.SEPARATOR + directory;
>
>>     CID 1250062:  Dm: Dubious method used  (FB.DM_DEFAULT_ENCODING)
>>>>     Found reliance on default encoding: String.getBytes().
>>>>
>>> 109           m.put(key.getColumnFamily(), key.getColumnQualifier(), new
> Value(newLocation.getBytes()));
> 110           if (log.isTraceEnabled()) {
> 111             log.trace("Replacing " + oldLocation + " with " +
> newLocation);
> 112           }
> 113           writer.addMutation(m);
> 114           try {
>
> ____________________________________________________________
> ____________________________________________
> *** CID 1250058:  DLS: Dead local store  (FB.DLS_DEAD_LOCAL_STORE)
> /server/tserver/src/main/java/org/apache/accumulo/tserver/log/LogSorter.java:
> 176 in org.apache.accumulo.tserver.log.LogSorter$LogProcessor.writeBuffer(java.lang.String,
> java.util.List, int)()
> 170               sortStop = System.currentTimeMillis();
> 171             }
> 172           }
> 173         }
> 174
> 175         private void writeBuffer(String destPath, List<Pair<LogFileKey,LogFileValue>>
> buffer, int part) throws IOException {
>
>>     CID 1250058:  DLS: Dead local store  (FB.DLS_DEAD_LOCAL_STORE)
>>>>     Dead store to part.
>>>>
>>> 176           Path path = new Path(destPath,
> String.format("part-r-%05d", part++));
> 177           FileSystem ns = fs.getVolumeByPath(path).getFileSystem();
> 178
> 179           @SuppressWarnings("deprecation")
> 180           MapFile.Writer output = new MapFile.Writer(ns.getConf(), ns,
> path.toString(), LogFileKey.class, LogFileValue.class);
> 181           try {
>
>
> ____________________________________________________________
> ____________________________________________
> To view the defects in Coverity Scan visit, http://scan.coverity.com/
> projects/736?tab=overview
>
> To unsubscribe from the email notification for new defects,
> http://scan5.coverity.com/cgi-bin/unsubscribe.py
>
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message