accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher <ctubb...@apache.org>
Subject Re: Deprecation removal for 1.7.0
Date Mon, 06 Oct 2014 21:47:31 GMT
See https://github.com/ctubbsii/accumulo/tree/ACCUMULO-3197 for the two
commits proposed for removing deprecated stuffs. One removes the
instance.getConfiguration nightmare that I'd really like to proceed with.
The other removes aggregators and other cleanup, which I don't feel
strongly about.


--
Christopher L Tubbs II
http://gravatar.com/ctubbsii

On Mon, Oct 6, 2014 at 5:20 PM, Josh Elser <josh.elser@gmail.com> wrote:

> Christopher, would it make sense to get a patch of the actual things
> you're looking at potentially removing, or would that be a waste of time
> this early?
>
> Mike Drob wrote:
>
>> I think before we can agree on a deprecation strategy, we need to firm up
>> the scope for this release plan.
>>
>>
>> What are the intentions for 1.7.0? Is it a "minor release" in the sense of
>> our previous minor releases, where we add a bunch of new features and
>> maintain some compatibility promises? Or are we going to try and make it a
>> truer minor release, where we cut down on the number of features and have
>> more conservative stakes in the ground?
>>
>
> Personally, I think 1.7.0 is shaping up to be a full-featured release
> given the amount of time since 1.6.0. I wanted to do a scrape of JIRA and
> collect the stuff that I know is done/in-progress.
>
>  Is this the same 1.7.0 that was going to be renamed to 2.0.0? Or an
>> intermediate release?
>>
>
> Intermediate -- the revised client API that Christopher is working on
> would be punted to a 1.8/2.0.
>
>
>  When do we need to deprecate the mapred API if we plan to drop Hadoop 1
>> support in Accumulo 2? (as has been discussed, but I'm not sure it was
>> ever
>> formally decided.)
>>
>> In general, I'm inclined to leave as much in as possible, and then if we
>> must remove things then do so in 2.0.0. I know that our compatibility
>> statement only promises one minor version, but that doesn't mean we have
>> to
>> be strict at every opportunity.
>>
>> Mike
>>
>> On Mon, Oct 6, 2014 at 4:03 PM, Billie Rinaldi<billie.rinaldi@gmail.com>
>> wrote:
>>
>>  Yes, we have both.  Neither is deprecated.
>>>
>>> On Mon, Oct 6, 2014 at 1:56 PM, Mike Drob<madrob@cloudera.com>  wrote:
>>>
>>>  Do we still have mapred(uce) stuff?
>>>>
>>>> On Mon, Oct 6, 2014 at 3:54 PM, Christopher<ctubbsii@apache.org>
>>>> wrote:
>>>>
>>>>  The main thing I'm looking at which is causing problems for me is the
>>>>> instance.getConfiguration() stuff. It was never well defined, usually
>>>>> didn't work or do what was expected of it, and is still being leveraged
>>>>> (incorrectly) by new code (replication, for instance, and I've already
>>>>> informed Josh), because of
>>>>> ServerConfigurationUtil.getConfiguration(Instance instance). It wasn't
>>>>> formally deprecated until 1.6.0, though.
>>>>>
>>>>> Aside from that, everything else is just a nice cleanup. A somewhat
>>>>> exhaustive list of what I was looking at was:
>>>>>
>>>>> Scanner timeout options
>>>>> extra batchwriter/batchdeleter factory methods
>>>>> some junk in MutationsRejectedException
>>>>> extra ZooKeeperInstance constructors
>>>>> securityOperations stuff from 1.5
>>>>> extra getSplits and flush in tableOperations
>>>>> Constants.NO_AUTHS
>>>>> KeyExtents.getKeyExtentsForRange
>>>>> an extra Value constructor which copies from a ByteBuffer
>>>>> iterators that moved packages in 1.4
>>>>> some protected getters in the mapred stuff
>>>>> unused RangeInputSplit in InputFormatBase
>>>>> LogFileKey/LogFileValue (old version)
>>>>>
>>>>>
>>>>> You can review the expected changes at
>>>>> https://github.com/ctubbsii/accumulo/tree/ACCUMULO-3197 (in two
>>>>>
>>>> commits,
>>>
>>>> one for instance stuff, the other for aggregators and everything else).
>>>>>
>>>>>
>>>>> --
>>>>> Christopher L Tubbs II
>>>>> http://gravatar.com/ctubbsii
>>>>>
>>>>> On Mon, Oct 6, 2014 at 4:11 PM, Sean Busbey<busbey@cloudera.com>
>>>>>
>>>> wrote:
>>>
>>>> No objection to removing aggregators.
>>>>>>
>>>>>> If anything first deprecated in 1.5 has managed to live this long
in
>>>>>>
>>>>> 1.7
>>>>
>>>>> I'd like to keep it so folks have an easier time getting off of 1.5
>>>>>>
>>>>> when
>>>>
>>>>> we
>>>>>
>>>>>> EOL it. But I realize some things have probably already been removed.
>>>>>>
>>>>>> On Mon, Oct 6, 2014 at 3:00 PM, Christopher<ctubbsii@apache.org>
>>>>>>
>>>>> wrote:
>>>>
>>>>> Re: ACCUMULO-3197
>>>>>>>
>>>>>>> First:
>>>>>>> Any objections to finally removing Aggregators in 1.7.0?
>>>>>>> They've been deprecated in favor of Combiners since 1.4.
>>>>>>>
>>>>>>> Second:
>>>>>>> Is there any API deprecated in 1.6.x or earlier that you really
>>>>>>>
>>>>>> want
>>>
>>>> preserved in 1.7.0?
>>>>>>> (I know we need to keep INSTANCE_DFS_{URI,DIR} properties for
>>>>>>>
>>>>>> volume
>>>
>>>> upgrades, at least.)
>>>>>>>
>>>>>>> --
>>>>>>> Christopher L Tubbs II
>>>>>>> http://gravatar.com/ctubbsii
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Sean
>>>>>>
>>>>>>
>>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message