accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Vines" <vi...@apache.org>
Subject Re: Review Request 27198: ACCUMULO-3236 introducing cloneInto feature
Date Wed, 29 Oct 2014 20:52:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27198/
-----------------------------------------------------------

(Updated Oct. 29, 2014, 8:52 p.m.)


Review request for accumulo.


Changes
-------

Applying first round of feedback changes


Bugs: ACCUMULO-3236
    https://issues.apache.org/jira/browse/ACCUMULO-3236


Repository: accumulo


Description
-------

Includes all code to support feature, including thrift changes
Includes minor code cleanup to TableLocator and items in the Bulk path to remove signature
items that are unused (arguments & exceptions)
Includes renaming of some bulk import functions to clarify their purpose (because they're
now multi-purpose)

Patch is based on 1.6, but we can choose to make it target only 1.7 if we choose (this conversation
should be taken up on jira, not in RB)


Diffs (updated)
-----

  core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 97f538d 
  core/src/main/java/org/apache/accumulo/core/client/impl/RootTabletLocator.java 97d476b 
  core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java 2792bcc

  core/src/main/java/org/apache/accumulo/core/client/impl/TabletLocator.java e396d82 
  core/src/main/java/org/apache/accumulo/core/client/impl/TabletLocatorImpl.java c550f15 
  core/src/main/java/org/apache/accumulo/core/client/impl/TimeoutTabletLocator.java bcbe561

  core/src/main/java/org/apache/accumulo/core/client/impl/thrift/TableOperation.java 7716823

  core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperationsImpl.java de19137

  core/src/main/java/org/apache/accumulo/core/client/mock/impl/MockTabletLocator.java 35f160f

  core/src/main/java/org/apache/accumulo/core/master/thrift/FateOperation.java f65f552 
  core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java
2ba7674 
  core/src/main/thrift/client.thrift 38a8076 
  core/src/main/thrift/master.thrift 38e9227 
  core/src/main/thrift/tabletserver.thrift 25e0b10 
  core/src/test/java/org/apache/accumulo/core/client/admin/TableOperationsHelperTest.java
1d91574 
  core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java 02838ed

  server/base/src/main/java/org/apache/accumulo/server/client/BulkImporter.java 27ab078 
  server/base/src/main/java/org/apache/accumulo/server/client/ClientServiceHandler.java ebea064

  server/base/src/main/java/org/apache/accumulo/server/security/SecurityOperation.java d0e6aea

  server/base/src/test/java/org/apache/accumulo/server/client/BulkImporterTest.java 3680341

  server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java 5818da3 
  server/master/src/main/java/org/apache/accumulo/master/tableOps/CloneIntoTable.java PRE-CREATION

  server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java 0778f5b 
  server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 03fe069 
  test/src/main/java/org/apache/accumulo/test/performance/thrift/NullTserver.java 0591b19

  test/src/test/java/org/apache/accumulo/test/functional/CloneIntoIT.java PRE-CREATION 

Diff: https://reviews.apache.org/r/27198/diff/


Testing
-------

Includes CloneIntoIT, which exercises all permutations of the flags. Existing BulkIT still
functions as intended for validation of no feature loss in refactoring exiting code for multi-purposing.


Thanks,

John Vines


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message