accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jenna Huston" <jenna.husto...@gmail.com>
Subject Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
Date Fri, 24 Oct 2014 19:56:03 GMT


> On Oct. 24, 2014, 2:38 a.m., Sean Busbey wrote:
> > server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java, lines 248-253
> > <https://reviews.apache.org/r/26514/diff/6/?file=729943#file729943line248>
> >
> >     First we use ServerConstants.TABLE_DIR to validate the input and then we use
Constants.HDFS_TABLES_DIR to set up the new location.
> >     
> >     Why the difference?
> >     
> >     It's hard for me to tell if this is expected behavior because there isn't a
method level javadoc.

I used the wrong constant.  ServerConstants.TABLE_DIR and Constants.HDFS_TABLES_DIR are the
same, so I just switched it.


- Jenna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26514/#review58226
-----------------------------------------------------------


On Oct. 23, 2014, 5:14 p.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26514/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 5:14 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3181
>     https://issues.apache.org/jira/browse/ACCUMULO-3181
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Delayed adding paths to volume options until after a volume is chosen.
> 
> 
> Diffs
> -----
> 
>   server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 10a864c 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java c87074b 
>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java fcecc37 
>   server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 
>   server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java f908d25

>   server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113

>   server/master/src/main/java/org/apache/accumulo/master/Master.java f894afc 
>   server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0

>   server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 5b64053

>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 2bd0b47

> 
> Diff: https://reviews.apache.org/r/26514/diff/
> 
> 
> Testing
> -------
> 
> Ran existing VolumeIT.
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message