accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
Date Fri, 24 Oct 2014 02:31:18 GMT


> On Oct. 22, 2014, 5:20 a.m., Sean Busbey wrote:
> > server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java, lines 80-83
> > <https://reviews.apache.org/r/26514/diff/5/?file=727603#file727603line80>
> >
> >     Please file a follow-on ticket to add docs to the user manual section on advanced
HDFS recovery to cover our use of this directory.
> >     
> >     * that it temporary directory exists
> >     * how to check how much space it is using 
> >     * what files might stick around in the case of failures and the relative safety
of deleting them
> 
> Jenna Huston wrote:
>     Can you open your own ticket so that what you want done comes across the way that
you intend.  This patch does not introduce the issue you are refering to.

Fair cop. opened as ACCUMULO-3265


- Sean


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26514/#review57745
-----------------------------------------------------------


On Oct. 23, 2014, 5:14 p.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26514/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2014, 5:14 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3181
>     https://issues.apache.org/jira/browse/ACCUMULO-3181
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Delayed adding paths to volume options until after a volume is chosen.
> 
> 
> Diffs
> -----
> 
>   server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 10a864c 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java c87074b 
>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java fcecc37 
>   server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 
>   server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java f908d25

>   server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113

>   server/master/src/main/java/org/apache/accumulo/master/Master.java f894afc 
>   server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0

>   server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 5b64053

>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 2bd0b47

> 
> Diff: https://reviews.apache.org/r/26514/diff/
> 
> 
> Testing
> -------
> 
> Ran existing VolumeIT.
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message