accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey" <s...@manvsbeard.com>
Subject Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
Date Wed, 22 Oct 2014 05:20:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26514/#review57745
-----------------------------------------------------------



server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java
<https://reviews.apache.org/r/26514/#comment98595>

    please add javadoc for what the purpose of this method and what the returned value is
supposed to represent.



server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java
<https://reviews.apache.org/r/26514/#comment98596>

    either use nested new Path(parent, child) constructors, or switch to using Path.SEPARATOR
instead of a literal '/'.



server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java
<https://reviews.apache.org/r/26514/#comment98599>

    no longer table directories. rename to configuredVolumes or something like that



server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java
<https://reviews.apache.org/r/26514/#comment98600>

    either use nested new Path(parent, child) constructors, or switch to using Path.SEPARATOR
instead of a literal '/'.



server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java
<https://reviews.apache.org/r/26514/#comment98601>

    either use nested new Path(parent, child) constructors, or switch to using Path.SEPARATOR
instead of a literal '/'.



server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java
<https://reviews.apache.org/r/26514/#comment98602>

    can these two really be on different volumes?
    
    if not, we shouldn't rely on the volumemanager to be coincidentally return the same twice.



server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java
<https://reviews.apache.org/r/26514/#comment98594>

    Please file a follow-on ticket to add docs to the user manual section on advanced HDFS
recovery to cover our use of this directory.
    
    * that it temporary directory exists
    * how to check how much space it is using 
    * what files might stick around in the case of failures and the relative safety of deleting
them



server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java
<https://reviews.apache.org/r/26514/#comment98593>

    nit: a string literal here is a code smell.
    
    maybe refactor ServerConstants.getTemporaryDirs to be getTemporaryDir and take a particular
Volume as another arg.



server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java
<https://reviews.apache.org/r/26514/#comment98605>

    either the extra "/tmp/" at the bottom is unneeded or the "accumuloDir" variable should
just be the base.



server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java
<https://reviews.apache.org/r/26514/#comment98606>

    nit: whitespace error.



server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java
<https://reviews.apache.org/r/26514/#comment98608>

    either use nested new Path(parent, child) constructors, or switch to using Path.SEPARATOR
instead of a literal '/'.



server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java
<https://reviews.apache.org/r/26514/#comment98609>

    either use nested new Path(parent, child) constructors, or switch to using Path.SEPARATOR
instead of a literal '/'.



server/master/src/main/java/org/apache/accumulo/master/Master.java
<https://reviews.apache.org/r/26514/#comment98610>

    either use nested new Path(parent, child) constructors, or switch to using Path.SEPARATOR
instead of a literal '/'.



server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java
<https://reviews.apache.org/r/26514/#comment98611>

    either use nested new Path(parent, child) constructors, or switch to using Path.SEPARATOR
instead of a literal '/'.



server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java
<https://reviews.apache.org/r/26514/#comment98612>

    either use nested new Path(parent, child) constructors, or switch to using Path.SEPARATOR
instead of a literal '/'.



server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
<https://reviews.apache.org/r/26514/#comment98613>

    either use nested new Path(parent, child) constructors, or switch to using Path.SEPARATOR
instead of a literal '/'.


Please run the full set of ITs.

- Sean Busbey


On Oct. 21, 2014, 6:25 p.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26514/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 6:25 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3181
>     https://issues.apache.org/jira/browse/ACCUMULO-3181
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Delayed adding paths to volume options until after a volume is chosen.
> 
> 
> Diffs
> -----
> 
>   server/base/src/main/java/org/apache/accumulo/server/ServerConstants.java 10a864c 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java c87074b 
>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java fcecc37 
>   server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 
>   server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java f908d25

>   server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113

>   server/master/src/main/java/org/apache/accumulo/master/Master.java f894afc 
>   server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0

>   server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 5b64053

>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 2bd0b47

> 
> Diff: https://reviews.apache.org/r/26514/diff/
> 
> 
> Testing
> -------
> 
> Ran existing VolumeIT.
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message