accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request 26514: ACCUMULO-3181 VolumeChooser usage doesn't always comply with implied API contract
Date Tue, 21 Oct 2014 16:27:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26514/#review57599
-----------------------------------------------------------



server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java
<https://reviews.apache.org/r/26514/#comment98376>

    this seems like the only code that called ServerConstants.getTemporaryDirs().  So I think
the method can be removed from server constants.  Not sure about the other methods in server
constants that were being used w/ choose(), but could just try removing them and see if causes
compile errors.


- kturner


On Oct. 20, 2014, 4:59 p.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26514/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2014, 4:59 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3181
>     https://issues.apache.org/jira/browse/ACCUMULO-3181
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Delayed adding paths to volume options until after a volume is chosen.
> 
> 
> Diffs
> -----
> 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java c87074b 
>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 5cbffc3 
>   server/base/src/main/java/org/apache/accumulo/server/util/FileUtil.java 0f7ac22 
>   server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java f978439

>   server/base/src/main/java/org/apache/accumulo/server/util/TabletOperations.java b8e7113

>   server/master/src/main/java/org/apache/accumulo/master/Master.java 2f04922 
>   server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java 0a3d1d0

>   server/master/src/main/java/org/apache/accumulo/master/tableOps/CreateTable.java 5b64053

>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 2bd0b47

> 
> Diff: https://reviews.apache.org/r/26514/diff/
> 
> 
> Testing
> -------
> 
> Ran existing VolumeIT.
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message