accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Newton" <eric.new...@gmail.com>
Subject Re: Review Request 26943: Changes to ZK for implicit retry handling
Date Mon, 20 Oct 2014 19:00:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26943/#review57379
-----------------------------------------------------------



fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCache.java
<https://reviews.apache.org/r/26943/#comment98067>

    nit: spelling "wil"



fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooUtil.java
<https://reviews.apache.org/r/26943/#comment98092>

    maybe add hashCode and equals?



fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooUtil.java
<https://reviews.apache.org/r/26943/#comment98093>

    nit: braces


- Eric Newton


On Oct. 20, 2014, 4:28 p.m., Josh Elser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26943/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2014, 4:28 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3242
>     https://issues.apache.org/jira/browse/ACCUMULO-3242
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> We didn't do some things correctly WRT zookeeper retries. Attempt to make it better.
Made a review in case people want to give some feedback
> 
> 
> Diffs
> -----
> 
>   fate/src/main/java/org/apache/accumulo/fate/zookeeper/IZooReaderWriter.java afc2250

>   fate/src/main/java/org/apache/accumulo/fate/zookeeper/Retry.java 4a37172 
>   fate/src/main/java/org/apache/accumulo/fate/zookeeper/RetryFactory.java 3fcb738 
>   fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCache.java d9eb243 
>   fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooReader.java 994f395 
>   fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooReaderWriter.java b29b88a

>   fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooUtil.java e0d8831 
>   fate/src/test/java/org/apache/accumulo/fate/zookeeper/RetryTest.java PRE-CREATION 
>   fate/src/test/java/org/apache/accumulo/fate/zookeeper/ZooReaderWriterTest.java PRE-CREATION

>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 5cbffc3 
>   server/base/src/main/java/org/apache/accumulo/server/security/handler/ZKPermHandler.java
3cac2e9 
> 
> Diff: https://reviews.apache.org/r/26943/diff/
> 
> 
> Testing
> -------
> 
> UTs/ITs
> 
> 
> Thanks,
> 
> Josh Elser
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message