accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs" <ctubbsii...@apache.org>
Subject Re: Review Request 26188: ACCUMULO-3176 Add ability to create a table with user specified initial properties
Date Mon, 06 Oct 2014 20:59:25 GMT


> On Oct. 6, 2014, 4:35 p.m., kturner wrote:
> > core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java,
line 241
> > <https://reviews.apache.org/r/26188/diff/3/?file=714180#file714180line241>
> >
> >     Needs a @since 1.7.0 javadoc tag

Make sure to add the suggested javadocs to the TableOperations interface, not the TableOperationsImpl.java
class. Javadocs are inherited from the interface, so that'd it'd be redundant to add to the
implementing class. However, do propagate annotations to sub-classes, as those are not inherited.
@Override, and @Deprecated (which is distinct form the javadoc tag @deprecated).


- Christopher


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26188/#review55575
-----------------------------------------------------------


On Oct. 6, 2014, 2:40 p.m., Jenna Huston wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26188/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2014, 2:40 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3176
>     https://issues.apache.org/jira/browse/ACCUMULO-3176
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Gives the ability to add properties to tables before they are initialized.  Therefore
these properties will take effect before the default tablet is created.  We create a NewTableConfiguration
class and send that in the create method as opposed to adding another method.  
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/NewTableConfiguration.java PRE-CREATION

>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java 97f538d

>   core/src/main/java/org/apache/accumulo/core/client/impl/TableOperationsImpl.java e46b9c9

>   core/src/main/java/org/apache/accumulo/core/client/mock/MockAccumulo.java 32dbb28 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTable.java 35cbdd2 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java 08750fe

>   core/src/test/java/org/apache/accumulo/core/client/impl/TableOperationsHelperTest.java
02838ed 
>   proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java a778add 
>   shell/src/main/java/org/apache/accumulo/shell/commands/CreateTableCommand.java 81b39d2

>   test/src/test/java/org/apache/accumulo/test/CreateTableWithNewTableConfigIT.java PRE-CREATION

>   test/src/test/java/org/apache/accumulo/test/ShellServerIT.java 5a068af 
> 
> Diff: https://reviews.apache.org/r/26188/diff/
> 
> 
> Testing
> -------
> 
> New IT, ran unit test and integration tests
> 
> 
> Thanks,
> 
> Jenna Huston
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message