accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Re: Review Request 26153: ACCUMULO-3182 WAL recovery on empty files doesn't fail
Date Wed, 01 Oct 2014 19:15:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26153/
-----------------------------------------------------------

(Updated Oct. 1, 2014, 7:15 p.m.)


Review request for accumulo.


Changes
-------

* Lifted the try/catch(EOFException) around main body of DfsLogger.readHeadeAndReturnStream
* Fixed an NPE in LogSorter.close when we get one of the WALs
* Used offline/online to trigger recovery on the table
* Used more MetadataSchema helper methods
* Added a delay to the GC start as it would sometimes remove the file we created before the
metadata reference was added


Bugs: ACCUMULO-3182
    https://issues.apache.org/jira/browse/ACCUMULO-3182


Repository: accumulo


Description
-------

Ensures that a WAL that was empty or missing a complete header (due to tservers dying before
it could happen) can be successfully recovered (by assuming that the lack of a complete header
means there is no data to recover). Currently against master, will pull back to 1.5 and merge
forward since it likely affects all branches.


Diffs (updated)
-----

  server/base/src/main/java/org/apache/accumulo/server/log/SortedLogState.java PRE-CREATION

  server/master/src/main/java/org/apache/accumulo/master/recovery/RecoveryManager.java 791aec8

  server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java b4fbfed 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 8de2b25 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/LogSorter.java 4badefa 
  server/tserver/src/main/java/org/apache/accumulo/tserver/log/MultiReader.java 541f075 
  server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogReader.java 681fbd3 
  server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
416a86e 
  server/tserver/src/test/java/org/apache/accumulo/tserver/log/MultiReaderTest.java a79e77e

  server/tserver/src/test/java/org/apache/accumulo/tserver/log/SortedLogRecoveryTest.java
fffa15e 
  server/tserver/src/test/java/org/apache/accumulo/tserver/log/TestUpgradePathForWALogs.java
f01ee10 
  test/src/test/java/org/apache/accumulo/test/MissingWalHeaderCompletesRecoveryIT.java PRE-CREATION


Diff: https://reviews.apache.org/r/26153/diff/


Testing
-------

New IT, ran UTs and ITs.


Thanks,

Josh Elser


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message