accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser" <josh.el...@gmail.com>
Subject Re: Review Request 26153: ACCUMULO-3182 WAL recovery on empty files doesn't fail
Date Wed, 01 Oct 2014 15:49:25 GMT


> On Oct. 1, 2014, 1:02 a.m., kturner wrote:
> > test/src/test/java/org/apache/accumulo/test/MissingWalHeaderCompletesRecoveryIT.java,
line 196
> > <https://reviews.apache.org/r/26153/diff/3/?file=709899#file709899line196>
> >
> >     Could use the following here...
> >     
> >     MetadataSchema.TabletsSection.getRow(tableId, null);

Ah, thanks! I missed that helpful method.


> On Oct. 1, 2014, 1:02 a.m., kturner wrote:
> > test/src/test/java/org/apache/accumulo/test/MissingWalHeaderCompletesRecoveryIT.java,
line 216
> > <https://reviews.apache.org/r/26153/diff/3/?file=709899#file709899line216>
> >
> >     this sleep should not be needed

I agree with you, but I still see https://issues.apache.org/jira/browse/ACCUMULO-2964 infrequently.
Offline'ing the table should actually preclude the unexplained Thrift exception (if I'm right
in that it's tied to the tserver restart) and it would actually make the test more generally
usable.


- Josh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26153/#review55044
-----------------------------------------------------------


On Sept. 30, 2014, 11:01 p.m., Josh Elser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26153/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 11:01 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-3182
>     https://issues.apache.org/jira/browse/ACCUMULO-3182
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Ensures that a WAL that was empty or missing a complete header (due to tservers dying
before it could happen) can be successfully recovered (by assuming that the lack of a complete
header means there is no data to recover). Currently against master, will pull back to 1.5
and merge forward since it likely affects all branches.
> 
> 
> Diffs
> -----
> 
>   server/base/src/main/java/org/apache/accumulo/server/log/SortedLogState.java PRE-CREATION

>   server/master/src/main/java/org/apache/accumulo/master/recovery/RecoveryManager.java
791aec8 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java b4fbfed

>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 8de2b25

>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/LogSorter.java 4badefa

>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/MultiReader.java 541f075

>   server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogReader.java 681fbd3

>   server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
416a86e 
>   server/tserver/src/test/java/org/apache/accumulo/tserver/log/MultiReaderTest.java a79e77e

>   server/tserver/src/test/java/org/apache/accumulo/tserver/log/SortedLogRecoveryTest.java
fffa15e 
>   server/tserver/src/test/java/org/apache/accumulo/tserver/log/TestUpgradePathForWALogs.java
f01ee10 
>   test/src/test/java/org/apache/accumulo/test/MissingWalHeaderCompletesRecoveryIT.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26153/diff/
> 
> 
> Testing
> -------
> 
> New IT, ran UTs and ITs.
> 
> 
> Thanks,
> 
> Josh Elser
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message