Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 09DCB177A8 for ; Mon, 29 Sep 2014 22:01:52 +0000 (UTC) Received: (qmail 41152 invoked by uid 500); 29 Sep 2014 22:01:51 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 41111 invoked by uid 500); 29 Sep 2014 22:01:51 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 41099 invoked by uid 99); 29 Sep 2014 22:01:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Sep 2014 22:01:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 76B881DDB15; Mon, 29 Sep 2014 22:01:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3765684335232163735==" MIME-Version: 1.0 Subject: Review Request 26153: ACCUMULO-3182 WAL recovery on empty files doesn't fail From: "Josh Elser" To: "accumulo" , "Josh Elser" Date: Mon, 29 Sep 2014 22:01:48 -0000 Message-ID: <20140929220148.18846.19613@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Josh Elser" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/26153/ X-Sender: "Josh Elser" Reply-To: "Josh Elser" X-ReviewRequest-Repository: accumulo --===============3765684335232163735== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26153/ ----------------------------------------------------------- Review request for accumulo. Bugs: ACCUMULO-3182 https://issues.apache.org/jira/browse/ACCUMULO-3182 Repository: accumulo Description ------- Ensures that a WAL that was empty or missing a complete header (due to tservers dying before it could happen) can be successfully recovered (by assuming that the lack of a complete header means there is no data to recover). Currently against master, will pull back to 1.5 and merge forward since it likely affects all branches. Diffs ----- server/base/src/main/java/org/apache/accumulo/server/log/SortedLogState.java PRE-CREATION server/master/src/main/java/org/apache/accumulo/master/recovery/RecoveryManager.java 791aec8 server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java b4fbfed server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java 8de2b25 server/tserver/src/main/java/org/apache/accumulo/tserver/log/LogSorter.java 4badefa server/tserver/src/main/java/org/apache/accumulo/tserver/log/MultiReader.java 541f075 server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogReader.java 681fbd3 server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java 416a86e server/tserver/src/test/java/org/apache/accumulo/tserver/log/MultiReaderTest.java a79e77e server/tserver/src/test/java/org/apache/accumulo/tserver/log/SortedLogRecoveryTest.java fffa15e server/tserver/src/test/java/org/apache/accumulo/tserver/log/TestUpgradePathForWALogs.java f01ee10 test/src/test/java/org/apache/accumulo/test/MissingWalHeaderCompletesRecoveryIT.java PRE-CREATION Diff: https://reviews.apache.org/r/26153/diff/ Testing ------- New IT, running existing unit tests right now. Will run ITs. Thanks, Josh Elser --===============3765684335232163735==--