Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-16-accumulo@git.apache.org>
In-Reply-To: <git-pr-16-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-3089: Create volume chooser
 from t...
Content-Type: text/plain
Message-Id: <20140924173916.B22CE8AFE76@tyr.zones.apache.org>
Date: Wed, 24 Sep 2014 17:39:16 +0000 (UTC)

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/16#discussion_r17987075
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java ---
    @@ -103,6 +103,25 @@
       void create(String tableName, boolean versioningIter, TimeType timeType) throws AccumuloException, AccumuloSecurityException, TableExistsException;
     
       /**
    +   * @param tableName
    +   *          the name of the table
    +   * @param limitVersion
    +   *          Enables/disables the versioning iterator, which will limit the number of Key versions kept.
    +   * @param timeType
    +   *          specifies logical or real-time based time recording for entries in the table
    +   * @param properties
    +   *          initial table properties the user wants
    +   * @throws AccumuloException
    +   *           if a general error occurs
    +   * @throws AccumuloSecurityException
    +   *           if the user does not have permission
    +   * @throws TableExistsException
    +   *           if the table already exists
    +   */
    +  void create(String tableName, boolean limitVersion, TimeType timeType, Map<String,String> properties) throws AccumuloException, AccumuloSecurityException,
    --- End diff --
    
    Instead of introducing yet another create table method, we could create a NewTableConfiguration class and pass that.
    
    ```java
    public class NewTableConfiguration {
      public NewTableConfiguration setTimeType(TimeType tt){...}
      public NewTableConfiguration setLimitVersions(boolean lv){...}
      public NewTableConfiguration setProperties(Map<String,String> properties){...}
    }
    ```
    
    And add a method like the following, and possibly deprecated existing create table methods (except for create(String) )
    
    ```java
     void create(String tableName, NewTableConfig ntc)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---