Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: ctubbsii <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-15-accumulo@git.apache.org>
In-Reply-To: <git-pr-15-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request: ACCUMULO-2841 Add Arbitrary Table
 Propertie...
Content-Type: text/plain
Message-Id: <20140910203934.2A98D888553@tyr.zones.apache.org>
Date: Wed, 10 Sep 2014 20:39:34 +0000 (UTC)

Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/15#discussion_r17387225
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java ---
    @@ -430,6 +430,21 @@ void rename(String oldTableName, String newTableName) throws AccumuloSecurityExc
        *           if the table does not exist
        */
       Iterable<Entry<String,String>> getProperties(String tableName) throws AccumuloException, TableNotFoundException;
    +  
    +  /**
    +   * Gets a specific property given its key. Note that recently changed properties may not be available immediately.
    +   * 
    +   * @param tableName
    +   *          the name of the table
    +   * @param property
    +   *          the name of a per-table property
    +   * @throws TableNotFoundException
    +   *           if the table does not exist
    +   * @throws AccumuloException
    +   *           if a general error occurs   * 
    +   * @return value of the specified property, null if property does not exist
    +   */
    +  String getProperty(String tableName, String property)throws AccumuloException, TableNotFoundException;
    --- End diff --
    
    This API change can be part of a separate issue. Now that you've pointed it out, it seems like an obvious oversight in our API (who wants to iterate over an iterable to get one property?), but it is probably outside the scope of this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---