Return-Path: X-Original-To: apmail-accumulo-dev-archive@www.apache.org Delivered-To: apmail-accumulo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0C035116AA for ; Wed, 3 Sep 2014 21:43:26 +0000 (UTC) Received: (qmail 69364 invoked by uid 500); 3 Sep 2014 21:43:25 -0000 Delivered-To: apmail-accumulo-dev-archive@accumulo.apache.org Received: (qmail 69324 invoked by uid 500); 3 Sep 2014 21:43:25 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 69306 invoked by uid 99); 3 Sep 2014 21:43:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Sep 2014 21:43:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C656E1DD3FA; Wed, 3 Sep 2014 21:43:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6003355018444029412==" MIME-Version: 1.0 Subject: Re: Review Request 25117: ACCUMULO-1957 From: "Josh Elser" To: "John Vines" , "Josh Elser" , keith@deenlo.com Cc: "Eric Newton" , "accumulo" Date: Wed, 03 Sep 2014 21:43:24 -0000 Message-ID: <20140903214324.16960.14651@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Josh Elser" X-ReviewGroup: accumulo X-ReviewRequest-URL: https://reviews.apache.org/r/25117/ X-Sender: "Josh Elser" References: <20140903213937.16960.32392@reviews.apache.org> In-Reply-To: <20140903213937.16960.32392@reviews.apache.org> Reply-To: "Josh Elser" X-ReviewRequest-Repository: accumulo --===============6003355018444029412== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 3, 2014, 9:39 p.m., kturner wrote: > > should anything be done in the shell relating to durability? could possibly allow inserts done via the shell to be done w/ differing durability. This may be useful is script wants to do a lot of inserts via the shell. I could see that as a follow-on (if at all). Anyone wanting to script some simple inserts should probably be using the proxy (I assume the perf is much better) which should get these fixes automatically, right? - Josh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25117/#review52248 ----------------------------------------------------------- On Sept. 3, 2014, 9:42 p.m., Eric Newton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25117/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2014, 9:42 p.m.) > > > Review request for accumulo, Josh Elser, kturner, and John Vines. > > > Bugs: ACCUMULO-1957 > https://issues.apache.org/jira/browse/ACCUMULO-1957 > > > Repository: accumulo > > > Description > ------- > > Allow tables and update sessions to be configured with different levels of durability (WAL sync'ing). > > > Diffs > ----- > > core/src/main/java/org/apache/accumulo/core/client/BatchWriterConfig.java e2ec22e > core/src/main/java/org/apache/accumulo/core/client/ConditionalWriterConfig.java 7671c35 > core/src/main/java/org/apache/accumulo/core/client/Durability.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/client/impl/ConditionalWriterImpl.java f5e6dd2 > core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java f2dd980 > core/src/main/java/org/apache/accumulo/core/client/impl/Writer.java bf226eb > core/src/main/java/org/apache/accumulo/core/conf/Property.java 9837867 > core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java f39a8bd > core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java 9c850a8 > core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TDurability.java PRE-CREATION > core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java 2ba7674 > core/src/main/thrift/tabletserver.thrift 25e0b10 > examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/ReadWriteExample.java a7b288d > server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 9b952ba > server/tserver/src/main/java/org/apache/accumulo/tserver/Mutations.java PRE-CREATION > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletMutations.java e814f0e > server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 57e3dee > server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java c01e54a > server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java 26e6891 > server/tserver/src/main/java/org/apache/accumulo/tserver/session/ConditionalSession.java 26668f6 > server/tserver/src/main/java/org/apache/accumulo/tserver/session/UpdateSession.java bc04a85 > server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java 6402797 > server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java 37950fc > server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletCommitter.java a5d197c > test/src/main/java/org/apache/accumulo/test/WrongTabletTest.java aeba2e0 > test/src/main/java/org/apache/accumulo/test/performance/thrift/NullTserver.java 6c34172 > test/src/test/java/org/apache/accumulo/test/functional/DurabilityIT.java PRE-CREATION > test/src/test/java/org/apache/accumulo/test/functional/SessionDurabilityIT.java PRE-CREATION > > Diff: https://reviews.apache.org/r/25117/diff/ > > > Testing > ------- > > Added DurabilityIT. > > > Thanks, > > Eric Newton > > --===============6003355018444029412==--