accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3089: Create volume chooser from t...
Date Fri, 26 Sep 2014 18:50:17 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/16#discussion_r18106626
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java ---
    @@ -18,5 +18,7 @@
     
     
     public interface VolumeChooser {
    +  String choose(VolumeChooserEnvironment env, String[] options);
    --- End diff --
    
    oh I just noticed that general.volume.chooser is marked experimental, so nevermind.  
If it were not experimental, I like the strategy of introducing a new prop, however it probably
not needed as long as that experimental notation makes it into the generated documentation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message