accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hustjl22 <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3089: Create volume chooser from t...
Date Fri, 26 Sep 2014 14:53:15 GMT
Github user hustjl22 commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/16#discussion_r18093257
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java ---
    @@ -261,7 +263,8 @@ private static String decommisionedTabletDir(ZooLock zooLock, VolumeManager
vm,
           throw new IllegalArgumentException("Unexpected table dir " + dir);
         }
     
    -    Path newDir = new Path(vm.choose(ServerConstants.getTablesDirs()) + "/" + dir.getParent().getName()
+ "/" + dir.getName());
    +    Path newDir = new Path(vm.choose(Optional.of(extent.getTableId().toString()), ServerConstants.getTablesDirs())
+ "/tables/" + dir.getParent().getName()
    --- End diff --
    
    Yes ServerConstants.getTablesDirs() does give you this. To make the paths consistant with
what would come in from the table property, I took away this part of the method.  And added
it back after the volume was chosen.  I guess it makes more sense to just call getBaseUris()
though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message