accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3089: Create volume chooser from t...
Date Fri, 26 Sep 2014 12:03:22 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/16#discussion_r18085325
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/admin/TableOperations.java
---
    @@ -103,6 +103,25 @@
       void create(String tableName, boolean versioningIter, TimeType timeType) throws AccumuloException,
AccumuloSecurityException, TableExistsException;
     
       /**
    +   * @param tableName
    +   *          the name of the table
    +   * @param limitVersion
    +   *          Enables/disables the versioning iterator, which will limit the number of
Key versions kept.
    +   * @param timeType
    +   *          specifies logical or real-time based time recording for entries in the
table
    +   * @param properties
    +   *          initial table properties the user wants
    +   * @throws AccumuloException
    +   *           if a general error occurs
    +   * @throws AccumuloSecurityException
    +   *           if the user does not have permission
    +   * @throws TableExistsException
    +   *           if the table already exists
    +   */
    +  void create(String tableName, boolean limitVersion, TimeType timeType, Map<String,String>
properties) throws AccumuloException, AccumuloSecurityException,
    --- End diff --
    
    The problem is that volumes are chosen once per tablet. So, if you are using the GeneralVolumeChooser
provided (which is really a per-table volume chooser), there is no ability to set the chooser
for this specific table until after the default one (the RandomVolumeChooser) has already
made a permanent decision for the default tablet. So, one could never write a volume chooser
that said "*Only* use this specific volume for this table." So, this feature is absolutely
essential if you want to implement a per-table volume chooser. I suppose it could be extracted
as a separate issue, which is an explicit prerequisite of this one, though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message