accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3089: Create volume chooser from t...
Date Fri, 26 Sep 2014 04:58:53 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/16#discussion_r18073817
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java ---
    @@ -313,8 +313,8 @@ private static void initFileSystem(Opts opts, VolumeManager fs, UUID
uuid, Path
         // the actual disk locations of the metadata table and tablets
         final Path[] metadataTableDirs = paths(ServerConstants.getMetadataTableDirs());
     
    -    String tableMetadataTabletDir = fs.choose(VolumeConfiguration.prefix(ServerConstants.getMetadataTableDirs(),
TABLE_TABLETS_TABLET_DIR));
    -    String defaultMetadataTabletDir = fs.choose(VolumeConfiguration.prefix(ServerConstants.getMetadataTableDirs(),
Constants.DEFAULT_TABLET_LOCATION));
    +    String tableMetadataTabletDir = fs.choose(Optional.<String>absent(), ServerConstants.getMetadataTableDirs())
+ "/tables/" + MetadataTable.ID + "/table_info";
    --- End diff --
    
    Again, a little confusing. We do have a tableId for the metadata table. Why isn't it being
passed into the volume chooser?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message