accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3089: Create volume chooser from t...
Date Fri, 26 Sep 2014 04:58:27 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/16#discussion_r18073807
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java ---
    @@ -232,9 +233,8 @@ public static boolean initialize(Opts opts, String instanceNamePath,
VolumeManag
     
         UUID uuid = UUID.randomUUID();
         // the actual disk locations of the root table and tablets
    -    String[] configuredTableDirs = VolumeConfiguration.prefix(VolumeConfiguration.getVolumeUris(SiteConfiguration.getInstance()),
    -        ServerConstants.TABLE_DIR);
    -    final Path rootTablet = new Path(fs.choose(configuredTableDirs) + "/" + RootTable.ID
+ RootTable.ROOT_TABLET_LOCATION);
    +    String[] configuredTableDirs = VolumeConfiguration.getVolumeUris(SiteConfiguration.getInstance());
    +    final Path rootTablet = new Path(fs.choose(Optional.<String>absent(), configuredTableDirs)
+ "/" + ServerConstants.TABLE_DIR+ "/" + RootTable.ID + RootTable.ROOT_TABLET_LOCATION);
    --- End diff --
    
    A bit confusion to provide optional when there is a `tableId` available for the Root table.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message