accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <>
Subject [GitHub] accumulo pull request: ACCUMULO-3089: Create volume chooser from t...
Date Fri, 26 Sep 2014 04:43:16 GMT
Github user joshelser commented on a diff in the pull request:
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/
    @@ -16,14 +16,65 @@
     package org.apache.accumulo.server.fs;
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +import java.util.List;
    +import java.util.Map;
     import java.util.Random;
    +import org.apache.accumulo.core.conf.AccumuloConfiguration.AllFilter;
    +import org.apache.accumulo.core.conf.AccumuloConfiguration.PropertyFilter;
    +import org.apache.log4j.Logger;
     public class RandomVolumeChooser implements VolumeChooser {
    +  private static final Logger log = Logger.getLogger(RandomVolumeChooser.class);
       Random random = new Random();
    +  public RandomVolumeChooser() {}
    -  public String choose(String[] options) {
    -    return options[random.nextInt(options.length)];
    +  public String choose(VolumeChooserEnvironment env, String[] options) {
    +    // Get the current table's properties, and find the preferred volumes property
    +    PropertyFilter filter = new AllFilter();
    +    Map<String,String> props = new java.util.HashMap<String,String>();
    +    ArrayList<String> prefVol = new ArrayList<String>();
    +    env.getProperties(props, filter);
    +    String volumes = props.get("table.custom.preferredVolumes");
    --- End diff --
    Thinking some more, if this does become its own standalone implementation, the value should
also be changed so that it reflects usage by this implementation. e.g if you named the new
class `FooVolumeChooser` the property could be something like ``
or similar (hopefully that's clear)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message