accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request: ACCUMULO-3089: Create volume chooser from t...
Date Fri, 26 Sep 2014 04:41:40 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/16#discussion_r18073546
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/RandomVolumeChooser.java
---
    @@ -16,14 +16,65 @@
      */
     package org.apache.accumulo.server.fs;
     
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +import java.util.List;
    +import java.util.Map;
     import java.util.Random;
     
    +import org.apache.accumulo.core.conf.AccumuloConfiguration.AllFilter;
    +import org.apache.accumulo.core.conf.AccumuloConfiguration.PropertyFilter;
    +import org.apache.log4j.Logger;
    +
     public class RandomVolumeChooser implements VolumeChooser {
    +  private static final Logger log = Logger.getLogger(RandomVolumeChooser.class);
       Random random = new Random();
    -  
    +
    +  public RandomVolumeChooser() {}
    --- End diff --
    
    Actually, this is really confusing because when the table property is set, this isn't
a "random volume" chooser at all -- it's a "choose a volume from this set" chooser. It would
make more sense to me for this code to live in its own volume chooser implementation rather
than push itself into the existing RandomVolumeChooser.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message