accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@deenlo.com
Subject Re: Review Request 25117: ACCUMULO-1957
Date Sat, 06 Sep 2014 01:24:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25117/#review52535
-----------------------------------------------------------



server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
<https://reviews.apache.org/r/25117/#comment91332>

    This will happend frequently.  Should probably be trace or removed.   If at trace level,
should avoid string concat.



server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
<https://reviews.apache.org/r/25117/#comment91331>

    I didn't open an issue earlier about making this a max function w/ unit test, it was just
a suggestion.  Opening an issue now since Josh and Eric thought it was a good idea.



proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java
<https://reviews.apache.org/r/25117/#comment91334>

    Why does the conditional writer code have a null check and this code does not?



proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java
<https://reviews.apache.org/r/25117/#comment91333>

    Would it be better to throw an exception here.  Seems like this code should never be reached.


- kturner


On Sept. 4, 2014, 7:14 p.m., Eric Newton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25117/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2014, 7:14 p.m.)
> 
> 
> Review request for accumulo, Josh Elser, kturner, and John Vines.
> 
> 
> Bugs: ACCUMULO-1957
>     https://issues.apache.org/jira/browse/ACCUMULO-1957
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Allow tables and update sessions to be configured with different levels of durability
(WAL sync'ing).
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/client/BatchWriterConfig.java e2ec22e 
>   core/src/main/java/org/apache/accumulo/core/client/ConditionalWriterConfig.java 7671c35

>   core/src/main/java/org/apache/accumulo/core/client/Durability.java PRE-CREATION 
>   core/src/main/java/org/apache/accumulo/core/client/impl/ConditionalWriterImpl.java
f5e6dd2 
>   core/src/main/java/org/apache/accumulo/core/client/impl/DurabilityImpl.java PRE-CREATION

>   core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
f2dd980 
>   core/src/main/java/org/apache/accumulo/core/client/impl/Writer.java 44314c7 
>   core/src/main/java/org/apache/accumulo/core/conf/Property.java 9837867 
>   core/src/main/java/org/apache/accumulo/core/conf/PropertyType.java f39a8bd 
>   core/src/main/java/org/apache/accumulo/core/master/thrift/MasterClientService.java
9c850a8 
>   core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TDurability.java PRE-CREATION

>   core/src/main/java/org/apache/accumulo/core/tabletserver/thrift/TabletClientService.java
2ba7674 
>   core/src/main/thrift/tabletserver.thrift 25e0b10 
>   core/src/test/java/org/apache/accumulo/core/client/BatchWriterConfigTest.java 231afe5

>   examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/ReadWriteExample.java
a7b288d 
>   proxy/pom.xml 4f53450 
>   proxy/src/main/cpp/AccumuloProxy.cpp 083c3ca 
>   proxy/src/main/cpp/proxy_types.h c320d39 
>   proxy/src/main/cpp/proxy_types.cpp d472402 
>   proxy/src/main/java/org/apache/accumulo/proxy/ProxyServer.java e65b956 
>   proxy/src/main/java/org/apache/accumulo/proxy/thrift/ConditionalWriterOptions.java
bb4ad51 
>   proxy/src/main/java/org/apache/accumulo/proxy/thrift/Durability.java PRE-CREATION 
>   proxy/src/main/java/org/apache/accumulo/proxy/thrift/WriterOptions.java 5f000a8 
>   proxy/src/main/python/ttypes.py 6a1b423 
>   proxy/src/main/ruby/proxy_types.rb 722e248 
>   proxy/src/main/thrift/proxy.thrift 6488f4f 
>   proxy/src/test/java/org/apache/accumulo/proxy/SimpleProxyIT.java 62e5b64 
>   proxy/src/test/java/org/apache/accumulo/proxy/TestProxyInstanceOperations.java ad21f91

>   proxy/src/test/java/org/apache/accumulo/proxy/TestProxyReadWrite.java c0049a0 
>   proxy/src/test/java/org/apache/accumulo/proxy/TestProxySecurityOperations.java e0b17ac

>   proxy/src/test/java/org/apache/accumulo/proxy/TestProxyTableOperations.java 87d3454

>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 9b952ba 
>   server/master/src/main/java/org/apache/accumulo/master/Master.java a8c6afa 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/Mutations.java PRE-CREATION

>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletMutations.java e814f0e

>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 57e3dee

>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java
2aa6380 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java c01e54a

>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/TabletServerLogger.java
26e6891 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/session/ConditionalSession.java
26668f6 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/session/UpdateSession.java
bc04a85 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/CommitSession.java
6402797 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java 37950fc

>   server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletCommitter.java
a5d197c 
>   server/tserver/src/test/java/org/apache/accumulo/tserver/log/DfsLoggerTest.java PRE-CREATION

>   shell/src/main/java/org/apache/accumulo/shell/commands/InsertCommand.java 19ae5b8 
>   test/pom.xml 80e8bee 
>   test/src/main/java/org/apache/accumulo/test/WrongTabletTest.java aeba2e0 
>   test/src/main/java/org/apache/accumulo/test/performance/thrift/NullTserver.java 6c34172

>   test/src/test/java/org/apache/accumulo/proxy/ProxyDurabilityIT.java PRE-CREATION 
>   test/src/test/java/org/apache/accumulo/proxy/SimpleProxyIT.java PRE-CREATION 
>   test/src/test/java/org/apache/accumulo/proxy/TestProxyInstanceOperations.java PRE-CREATION

>   test/src/test/java/org/apache/accumulo/proxy/TestProxyReadWrite.java PRE-CREATION 
>   test/src/test/java/org/apache/accumulo/proxy/TestProxySecurityOperations.java PRE-CREATION

>   test/src/test/java/org/apache/accumulo/proxy/TestProxyTableOperations.java PRE-CREATION

>   test/src/test/java/org/apache/accumulo/test/ShellServerIT.java 04fdd1c 
>   test/src/test/java/org/apache/accumulo/test/functional/DurabilityIT.java PRE-CREATION

>   test/src/test/java/org/apache/accumulo/test/functional/SessionDurabilityIT.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/25117/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eric Newton
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message